D8CORE-3161: reduce load more button size

[jenbreese]

READY FOR REVIEW

Summary

• Changed the Load More button from a button-big to a button-primary
• Moved the SCSS to the Stanford Basic theme.
• Done on People, Events, and News.
• Publications already had the primary button size but removed the duplicate code.

Review By (Date)

• 9/8

Criticality

• Normal
• Affects all sites using or inheriting from the Stanford Basic theme
• @jdwjdwjdw @rebeccahongsf @rmundstock - FYI

Urgency

• Normal

Review Tasks

Setup tasks and/or behavior to test

1. Check out this branch
2. Rebuild Cache and import config drush cr ; drush ci
3. Create/Generate enough content to get the load more button on the News, Events and People list page
4. Verify the large Load More button is now a regular sized one.
5. Create list paragraphs with the 4 types with a number cap and verify the button is small on the list too.

New

Old

Site Configuration Sync

• Is there a config:export in this PR that changes the config sync directory? NO

Front End Validation

• Design is approved by @ user?
• HTML validation: Is the markup using the appropriate semantic tags and passes validation? Or, QA request ticket created?
• Cross-browser testing: Has been performed? Or, QA request ticket created?
• Automated accessibility: Scans performed? Or, QA request ticket created?
• Manual accessibility: Manually tested? Or, QA request ticket created?

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided? eg (unit, behat, or codeception)

Code security

• Are all forms properly sanitized?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

Affected Projects or Products

• Affects all sites using or inheriting from the Stanford Basic theme

Associated Issues and/or People

• D8CORE-3161
• D8CORE-3161: change the load more button to primary stanford_person#151
• D8CORE-3161: Changed the load more button size stanford_news#132
• D8CORE-3161: reduce load more button size #83
• D8CORE-3161: moving pager css to theme stanford_basic#242
• D8CORE-3161: moving the pager to the theme stanford_publication#47
• @jdwjdwjdw @rebeccahongsf @rmundstock - FYI

Resources

• AMP Tool
• Accessibility Manual Test Script
• HTML Validator
• Browserstack and link to Browserstack Credentials

[pookmish]

seems legit

[pookmish]

Just before I merged this i saw the other 3 identical PRs. Should we just generalize it and throw it into stanford_basic?

[jenbreese]

I'm not sure. If it isn't there for News (I think) the button is just a link. Should the modules be pretty close to stand alone without the Stanford Basic theme?

[pookmish]

The modules can be "good enough". we could remove the styling from the module and move it to a more generalized location.

I'm toying with the idea of a stanford_profile_theme so that we can just move everything to that one location and deprecate all of the styles in the modules (or move them to a submodule)

[jenbreese]

In that case I think it is a good idea. It is 3x the same code.