Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the imported redirects to point at the node instead of the alias #168

Merged
merged 1 commit into from Jan 20, 2022
Merged

Modify the imported redirects to point at the node instead of the alias #168

merged 1 commit into from Jan 20, 2022

Conversation

pookmish
Copy link
Contributor

@pookmish pookmish commented Jan 13, 2022 •
edited

READY FOR REVIEW

Summary

  • When importing a list of redirect, the destination might be /about but it is saved in that way in the database. It's saved like internal:/about. Ideally it would target the node itself if there is one. This will convert the alias to the internal path that targets the entity.

Need Review By (Date)

  • 1/20

Urgency

  • medium

Steps to Test

  1. checkout this branch and clear caches
  2. create a csv for redirects like:
From,To
/foo-bar,/research
  1. Import the csv on /admin/config/search/redirect/import
  2. edit the newly created redirect
  3. validate it is tied to the node and not just the alias.

See Also

@pookmish pookmish requested a review from imonroe January 13, 2022 18:31
@pookmish
Copy link
Contributor Author

poke

imonroe
imonroe approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@imonroe imonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on my system. No test since it's in the .module file.

@imonroe imonroe merged commit 8a7ec23 into 8.x-1.x Jan 20, 2022
@imonroe imonroe deleted the redirect-tweaks branch January 20, 2022 23:49
pookmish added a commit that referenced this pull request Jan 28, 2022
@pookmish
8.1.31
772fb83 
- Purge the source url when a redirect is saved (#169)
- Modify the imported redirects to point at the node instead of the alias (#168)
- Check if the form as VBO before sorting actions (#167)
- D8CORE-5183: fixes to the after in a heading for the new localist work (#166)
- D8CORE-5106: fixing the spacing between basic cards when in a list (#165)
- D8CORE-4833: Added sorting to the node actions (#159)
- updated tests for D9.3 (#164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imonroe imonroe imonroe approved these changes

Assignees

@imonroe imonroe

Labels
size/xs
Projects
None yet
Milestone
No milestone
2 participants
@pookmish @imonroe