Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGGD-16 | @jdwjdwjdw | Update grad grow card link styles #61

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Oct 24, 2023

READY FOR REVIEW

Summary

  • VGGD-16: FED // Grad Grow Landing page
  • Updating grad grow card link text decoration / li line-height after A11y/designer review

Review By (Date)

  • When convenient

Urgency

  • Normal

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add a basic page with a card paragraph. Inside the card description Source, add the following code:
<div class="grad-grow--card">
    <h3>
        <a class="su-link--action" href="/">Communication</a>
    </h3>
    <ul>
        <li>
            <a href="/">Writing</a>
        </li>
        <li>
            <a href="/">Public Speaking</a>
        </li>
        <li>
            <a href="/">Interpersonal communication</a>
        </li>
    </ul>
</div>
  1. Confirm that the links inside of the unordered list are now underlined by default, with no underline on hover/focus, matching figma, and that the li's now have a line-height of 1.3.
  2. Review code 馃嵉

Associated Issues and/or People

  • VGGD-16: FED // Grad Grow Landing page

@mdyoung3
Copy link
Contributor

@jdwjdwjdw Works for me. (I removed the grad-grow--card parent class, and it looks like it will still works. )

Approved.

@jdwjdwjdw jdwjdwjdw merged commit 16f3203 into 11.x Oct 30, 2023
4 checks passed
@jdwjdwjdw jdwjdwjdw deleted the VGGD-16--card-links-adjustment branch October 30, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants