Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grad grow filter card pill styles #76

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Fix grad grow filter card pill styles #76

merged 1 commit into from
Nov 21, 2023

Conversation

jdwjdwjdw
Copy link
Contributor

@jdwjdwjdw jdwjdwjdw commented Nov 17, 2023 •
edited by jira bot

READY FOR REVIEW

Summary

  • Fix grad grow filter card pill styles after recent changes to 11.x

Review By (Date)

  • ASAP

Urgency

  • High

Review Tasks

Setup tasks and/or behavior to test

  1. Check out this branch
  2. Add some example events and resources (with competencies), and then add the grad-grow filter view to a basic page.
  3. Confirm that the Event and Resource card competencies have the correct pill styles applied
  4. Review code 馃尨

Associated Issues and/or People

  • VGGD-26: Update view mode and pattern UI

@mdyoung3 mdyoung3 merged commit de9f5d7 into 11.x Nov 21, 2023
4 checks passed
@mdyoung3 mdyoung3 deleted the VGGD-26--update-competency-pill-styles branch November 21, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdyoung3 mdyoung3 mdyoung3 approved these changes

Assignees

@mdyoung3 mdyoung3

Labels
size/xs
Projects
None yet
Milestone
No milestone
2 participants
@jdwjdwjdw @mdyoung3