Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme.md, requirements.txt, and add web-demo.py #6

Merged

Conversation

yvrjsharma
Copy link
Contributor

Added a Gradio demo for local use and updated readme and requirements files accordingly.

@eliphatfs
Copy link
Collaborator

I think we should integrate the rembg+SAM-based foreground segmentation into the gradio demo too (check the streamlit demo code); BTW what's wrong with the streamlit demo? Aren't they the same kind of thingy to use?

@yvrjsharma
Copy link
Contributor Author

image

Thank you for your feedback! I appreciate your input. The reason for adding a Gradio demo in addition to the existing Streamlit demo was to provide users with an alternative interface for Zero123plus, making it more accessible and bit more user-friendly for a wider audience.

However, I would like to clarify that the rembg+SAM-based foreground segmentation is already included in the Gradio demo (see the accordion in this Gradio UI snapshot). I understand the Gradio demo offers users the same functionality as the Streamlit demo but through a different interface. My intention was to provide users with a choice in how they interact with the application, whether it's through the Streamlit or Gradio interface.

That said, I am more than happy to ensure that both demos offer a consistent user experience by integrating any missing features from the Streamlit demo into the Gradio demo. This will ensure that users can achieve the same results and experience regardless of the interface they choose to use. Let me know if you think I am still missing any features and I will work on making these changes and update the pull request accordingly.

Thank you for your understanding, and I look forward to improving the project's accessibility and usability.

@eliphatfs
Copy link
Collaborator

We apply SAM after doing rembg, for example in

mask = SAMAPI.segment_api(numpy.array(img)[:, :, :3], mask)

I don't see the logic in the proposed pr. But let's merge it first and fix this in another issue.

@eliphatfs eliphatfs merged commit d6c50cb into SUDO-AI-3D:main Oct 24, 2023
@eliphatfs eliphatfs mentioned this pull request Oct 24, 2023
@eliphatfs
Copy link
Collaborator

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants