feat(components/molecule/avatar): handle background color for avatar #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
requested review from
kikoruiz,
andresin87,
rmoralp,
sui-bot and
arnau-rius
as code owners
|
jordevo
reviewed
Sep 29, 2022
| @@ -192,7 +192,7 @@ describe(json.name, () => { | |||
| const {getByText} = setup(props) | |||
|
|
|||
| // Then | |||
| expect(getByText('JS')).to.be.visible | |||
| expect(getByText('js')).to.be.visible | |||
There was a problem hiding this comment.
cool initials π
so the test is no longer should render fallback name initials uppercase?
There was a problem hiding this comment.
The thing is I've changed the way initials are "uppercased", using the CSS transform property instead of the .toUpperCase() js method. The final visual result is the same :)
jordevo
approved these changes
Sep 29, 2022
andresin87
approved these changes
Sep 29, 2022
ferransimon
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
molecule/avatar
π Show
Types of changes
Description, Motivation and Context
When a passed src image was erroring and the
nameproperty was passed, the background-color for the fallback was not applied correctly.