refactor(components/molecule/field): replace cloneElement with injector #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oegea
requested review from
kikoruiz,
andresin87,
rmoralp,
sui-bot and
arnau-rius
as code owners
|
|
@andresin87 Would it be possible to get the hacktoberfest-accepted label on my prs please? 🙏 👀 (except on the related with the molecule/avatar, which seems to be duplicated. Should we close it?) |
andresin87
added
the
hacktoberfest-accepted
andresin87
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #2321
molecule/field
❓ AskTASK: #2321
Types of changes
Description, Motivation and Context
This PRs replaces
cloneElementstatements frommolecule/fieldin favor of using the suiInjectorcomponent.Submitted for the hacktoberfest event. It should not have any visual effect, just a refactor.