Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed vacuum bug and added warning for memory leak which occurs with … #85

Merged
merged 11 commits into from Mar 18, 2019

Conversation

jboes
Copy link
Collaborator

@jboes jboes commented Mar 12, 2019

…getting voronoi neighbors of pointy unit cell

…getting voronoi neighbors of pointy unit cell
kirstenwinther
kirstenwinther previously approved these changes Mar 15, 2019
Copy link
Member

@kirstenwinther kirstenwinther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the Cathub submodule - no problem.

@coveralls
Copy link

coveralls commented Mar 18, 2019

Pull Request Test Coverage Report for Build 320

  • 5 of 6 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.5%) to 65.748%

Changes Missing Coverage Covered Lines Changed/Added Lines %
catkit/gen/utils/connectivity.py 3 4 75.0%
Totals Coverage Status
Change from base Build 309: -1.5%
Covered Lines: 2194
Relevant Lines: 3337

💛 - Coveralls

@jboes jboes merged commit 2254a88 into SUNCAT-Center:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants