Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when taking picture #111

Closed
PotentialIngenuity opened this issue Apr 15, 2017 · 11 comments
Closed

Crash when taking picture #111

PotentialIngenuity opened this issue Apr 15, 2017 · 11 comments

Comments

@PotentialIngenuity
Copy link

When I try to take a picture the app crashes. From what I can tell from the log, the app didn't have permission to use the camera.

Edit:
I fixed this by manually enabling the camera permission for the app. Does this happen to everyone? If so you should find out why the permission wasn't enabled by default. An average user won't know how to do this by themselves.

@SUPERCILEX
Copy link
Owner

@blake1029384756 Ouch! 😢 I'm so confused right now. Late last night I added the camera permissions to the manifest because I felt like it was wrong to not have it. The WTF thing is that without the permission, I didn't get a security exception, but with the permission, the app started crashing. Anyway, I've fixed, but it doesn't make any sense. Maybe a security hole in Android? (That's unlikely) IDK, anyway, it's fixed.

@SUPERCILEX
Copy link
Owner

Nevermind, I'm still seeing the crash.

@SUPERCILEX SUPERCILEX reopened this Apr 15, 2017
@vannaka
Copy link

vannaka commented Apr 15, 2017

@SUPERCILIX, does the crash only happen on Nougat devices? I know on Android 7.X they introduced a new permissions system.

@PotentialIngenuity
Copy link
Author

@vannaka no, I'm on android 6.0.1

@PotentialIngenuity
Copy link
Author

PotentialIngenuity commented Apr 15, 2017

Here is the log from the crash. The Error starts on line 128
mediacrash.txt

@PotentialIngenuity PotentialIngenuity changed the title Crash when taking picture(fixed) Crash when taking picture Apr 15, 2017
@SUPERCILEX
Copy link
Owner

@blake1029384756 @vannaka Don't worry guys! 😄 I've just been trying to do a lot of stuff at once, should be fine now. @vannaka Yeah, I get the crashes in Firebase, but thanks anyway! @vannaka Yeah, the new permission stuff happened in 6.x (Marshmellow) and I'm already setup for that with spreadsheet exporting. I just made a bunch of typos! 🤣

@PotentialIngenuity
Copy link
Author

@SUPERCILEX just trying to give as much info as I can to be of some help. Haha, gl finding them

@SUPERCILEX
Copy link
Owner

Ok, this should work! 🚀 We'll see once the build finishes, but basically I made a bunch of typos when requesting the permissions. 😄

@SUPERCILEX
Copy link
Owner

@blake1029384756 Yeah, it's totally fine!

@PotentialIngenuity
Copy link
Author

It works! Congrats!

@SUPERCILEX
Copy link
Owner

Just updated RS on my Pixel and yup, it worked! 😁 Thank you guys being alpha testers and gently telling me when I'm being stupid. 🤣

SUPERCILEX added a commit that referenced this issue May 23, 2017
fixes #111

Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants