Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add easy match number selection field #199

Closed
andrewda opened this issue Apr 4, 2018 · 7 comments
Closed

Add easy match number selection field #199

andrewda opened this issue Apr 4, 2018 · 7 comments

Comments

@andrewda
Copy link
Contributor

andrewda commented Apr 4, 2018

Right now scouts are match agnostic. Make a new field to allow for the selection of a match, or entering the match number. This should also be the name of the scout instead of relying on the human to name the scout, which rarely gets done.

One option could be just having a dropdown with "Q", "QF", "SF", "F" with a text box next to it for the match number, followed by a conditional second text box if we're in "QF" or "SF" for the series number.

Another option could be getting match schedules from TBA and having a searchable dropdown of all the matches.

The latter will be needed for #55, so might be a good idea to spend the time on it anyways, but having the former as a backup in case there isn't any match schedule (or one couldn't be downloaded before we lost internet access) would be a good idea too.

@andrewda
Copy link
Contributor Author

andrewda commented Apr 4, 2018

Also, if more linking to events gets done, naming the scouts something like {eventId}_{matchId} would be really good too so we can easily link it to the TBA match using the same format.

@andrewda
Copy link
Contributor Author

andrewda commented Apr 4, 2018

When selecting the match from a dropdown, only the matches in which that team plays should be shown.

@SUPERCILEX
Copy link
Owner

Yup, already planned for #55. The scout names will be XXX-### where XXX = QF. I'm not going to provide any UI for this since Auto Scout will automatically create a new scout for you and bring you to the right Activity from the notification.

@andrewda
Copy link
Contributor Author

andrewda commented Apr 4, 2018

There should be UI to change it in case anything is wrong. Manual override but default it to what you think it is. And for the number follow TBA's naming: qm54, qf2m2, sf1m2, and f1m1.

@SUPERCILEX
Copy link
Owner

Nah to both. The match names needs to be human readble and the override won't be there. You'll be able to say the match number you're currently playing and you'll tell it when to move on to QF or F etc. Foolproof that way.

@andrewda
Copy link
Contributor Author

andrewda commented Apr 5, 2018

Hmm okay, that's kinda what I was talking about wrt the "override". Also, I'm good with a human readable format ("Qualification 54", "Quarterfinal 2 Match 2", "Semifinal 1 Match 2" and "Final 1 Match 1"), but when exporting it it'd be super nice to have the match code so it can be easily linked to the TBA match without having to parse it in a gross way.

@SUPERCILEX
Copy link
Owner

Yeah, that'll only be for the JSON though. I've added that to the list, good idea. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants