Add support for Fronius 3 phase inverter and Smart Meter 63A-3 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klew
requested changes
Jun 24, 2021
| setCurrent(2, currentCurrent[2]); | ||
| setVoltage(2, currentVoltage[2]); | ||
| setPowerActive(2, currentCurrent[2] * currentVoltage[2]); | ||
| //setPowerActive(0, currentPower); |
Comment on lines
+94
to
+101
| case IAC: { | ||
| float curCurrent = atof(varValue); | ||
| Serial.print(F("Current: ")); | ||
| Serial.println(curCurrent); | ||
| //currentCurrent[0] = curCurrent * 1000; | ||
|
|
||
| break; | ||
| } |
Comment on lines
+110
to
+116
| case UAC: { | ||
| float curVoltage = atof(varValue); | ||
| Serial.print(F("Voltage: ")); | ||
| Serial.println(curVoltage); | ||
| //currentVoltage[0] = curVoltage * 100; | ||
|
|
||
| break; |
Comment on lines
+248
to
+249
| strcpy(buf, "GET /solar_api/v1/GetInverterRealtimeData.cgi?Scope=Device&DeviceID="); | ||
| strcat(buf, idBuf); |
There was a problem hiding this comment.
you can move it above "if" and remove it from second if section
| strcpy(buf, "GET /solar_api/v1/GetInverterRealtimeData.cgi?Scope=Device&DeviceID="); | ||
| strcat(buf, idBuf); | ||
| strcat(buf, "&DataCollection=3PInverterData HTTP/1.1"); | ||
| pvClient.println(buf); |
There was a problem hiding this comment.
This line can be moved below both "ifs"
Comment on lines
+86
to
+93
| case PAC: { | ||
| float curPower = atof(varValue); | ||
| Serial.print(F("Current power: ")); | ||
| Serial.println(curPower); | ||
| currentPower = curPower * 100000; | ||
|
|
||
| break; | ||
| } |
| port(port), | ||
| buf(), | ||
| totalGeneratedEnergy(0), | ||
| currentPower(0), |
| int port; | ||
| char buf[80]; | ||
| unsigned _supla_int64_t totalGeneratedEnergy; | ||
| _supla_int_t currentPower; |
| buf(), | ||
| totalGeneratedEnergy(0), | ||
| currentPower(0), | ||
| currentActivePower{}, |
| char buf[80]; | ||
| unsigned _supla_int64_t totalGeneratedEnergy; | ||
| _supla_int_t currentPower; | ||
| _supla_int_t currentActivePower[3]; |
|
Please comment if you plan to address above comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Fronius 3 phase inverter and Fronius 3 phase Smart Meter
Proposed changes are tested on Fronius Symo *.0-3 M inverter (highest possible firmware) with Smart Meter 63A-3, but there is also possibility to use only one of them (for example only inverter without Smart Meter).
Fronius API does not gives all information divided to 3 phases, so such data is attached to first phase (anyway, sum counts correctly).