Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SURF Design System: redesign SBS header #466

Closed
arnoutt opened this issue Jan 5, 2023 · 15 comments
Closed

SURF Design System: redesign SBS header #466

arnoutt opened this issue Jan 5, 2023 · 15 comments
Labels
SDS Stories related to SURF Design System UI User interface only stories
Milestone

Comments

@arnoutt
Copy link

arnoutt commented Jan 5, 2023

Note: with header, I mean everything from the top of the page until the tables where the organisations/COs/members are listed, including the table header itself (the tabs).

Regarding the orange part of the header:

  • The username chevron (user-info component) must be redesigned to conform to SDS (should contain first + last name as well as the url of the organisation the user is logged in with)
  • The mouse over / hover style is not in line with the SDS
  • There should be a separator before the logout option

Regarding the object-header part (the gray area of the header):

  • Breadcrumb nav. should be made in line with SDS
  • The SDS has a different style of filling the header with titles/descriptions/properties, make sure SRAM conforms to it
  • The tab nav (table header) looks different in SRAM than in the SDS

Note1: likely, the object-header part will need some discussion, as probably not all properties will fit straight away.

Note2: possibly, we would like to get rid of the 2nd chevron menu, as it is not an existing element in the SDS. We should discuss that too.

@arnoutt arnoutt added UI User interface only stories SDS Stories related to SURF Design System labels Jan 5, 2023
@arnoutt arnoutt self-assigned this Jan 5, 2023
@FlorisFokkinga
Copy link
Contributor

Use the header with metadata-list, which is now available in the SDS: https://design.surf.nl/#object-header

Image

@FlorisFokkinga
Copy link
Contributor

Specifieke gevallen oplossen.

@FlorisFokkinga FlorisFokkinga self-assigned this Mar 6, 2023
@oharsta oharsta added the discuss Needs to be discussed; do not implement as is. label Mar 8, 2023
@FlorisFokkinga
Copy link
Contributor

ORG

image

CO

image

image

Service

image

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Mar 9, 2023

Org

  • Keep title and description above the metadata-list.
  • Organisation domains
    • abc.nl
    • abcuniversiteit.nl
  • Users from these domains
    • can {request|create} collaborations

CO for admins

  • Keep title and description above the metadata-list.
  • Expires
    • March 16, 2023
  • Membership request
    • Copy link ⎘
  • Member list
    • {Visible|Hidden}

CO for members

  • Members
    • 3 members
    • 2 groups
  • Organised by
    • <admin 1 name>
    • <admin 2 name>
    • and 2 others
  • More information
    • Website
  • Expires
    • March 16, 2023
  • Membership
    • Active (i)

Service

@oharsta
Copy link
Collaborator

oharsta commented Mar 13, 2023

@FlorisFokkinga Is this story ready? Or do we need to resolve the matter of not-enough-space?

@FlorisFokkinga FlorisFokkinga removed the discuss Needs to be discussed; do not implement as is. label Mar 17, 2023
@FlorisFokkinga
Copy link
Contributor

We'll have to make a few decisions about what to show and how to show it.

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Mar 20, 2023

I think we can put multple (more or less similar) links in a cell, and also list an array of values for an attribute in a cell.
I've edit the bulleted list to contain five columns at most.

image

Lets's limit this to 4 lines per cell, for example:

  • Name
  • Value 1
  • Value 2
  • Value 3

And if more values,

  • Name
  • Value 1
  • Value 2
  • Two more values

I suppose for email addresses, the 'two more values' should be a mailto-link.

@FlorisFokkinga FlorisFokkinga added this to the v22 milestone Mar 20, 2023
@arnoutt
Copy link
Author

arnoutt commented Mar 20, 2023

One minor adjustment to the mockup Floris made: the vertical lines should not be longer than the actual content. So in the mockup above, the first 2 vertical grey lines should be shorter.

@FlorisFokkinga
Copy link
Contributor

  • Limit to 5 wide
  • Limit to 2 high if possible, 3 is permissable
  • Don't allow user input
  • Move the rest to a new 'about' tab
  • Consider a service login button on the service about tab

@FlorisFokkinga
Copy link
Contributor

FlorisFokkinga commented Mar 23, 2023

Org

  • Keep title and description above the metadata-list.
  • Organisation domains
    • abc.nl
    • abcuniversiteit.nl
  • Users from these domains
    • can {request|create} collaborations

Keeping the organisation domains in the header, violates the hight limit and allows user input. For organisational domains, this seems the best option. Ususally there's only one and it's too little information to offload to a tab.

CO for admins

  • Keep title and description above the metadata-list.
  • Expires
    • March 16, 2023
  • Membership request
    • Copy link ⎘
  • Member list
    • {Visible|Hidden}

CO for members

  • Members
    • 3 members
  • Groups
    • 2 groups
  • More information
    • Website
  • Expires (hide if no date is set)
    • March 16, 2023
  • Your membership
    • Active (i)

Tab 'About'

Always show the admin's names and email addresses under the 'Members (#)' header, even if 'Disclose member information' and/or 'Disclose email information' are disabled.
image

Service

Tab 'Contact'

Create a tab 'Contact', which is not shown for users that can see the 'Details' and 'Admins' tab (service admins and platform admins). On that tab, display text as heades and simply list the email addresses:

oharsta added a commit that referenced this issue Mar 23, 2023
@FlorisFokkinga
Copy link
Contributor

Extreme cases

Organisation
image
CO
image
CO as member
image
Service
image
Service as member (of a connected CO)
image

I think it generally works well enough.

@FlorisFokkinga
Copy link
Contributor

@oharsta, the new service about tab needs some padding to the left of its contents.

@arnoutt
Copy link
Author

arnoutt commented Mar 30, 2023

I'm not really happy with it and would like to ask the UX-expert to propose a new design. If that is going to take a while I'm OK with releasing it like this, but would really prefer to have a new/better design.

oharsta added a commit that referenced this issue Mar 31, 2023
@oharsta oharsta assigned FlorisFokkinga and unassigned oharsta Mar 31, 2023
@oharsta
Copy link
Collaborator

oharsta commented Mar 31, 2023

@FlorisFokkinga Assigned this to you for follow-up (or not).

oharsta added a commit that referenced this issue Apr 4, 2023
@baszoetekouw
Copy link
Member

We're releasing the current design in v22. Followup in #623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SDS Stories related to SURF Design System UI User interface only stories
Projects
Archived in project
Development

No branches or pull requests

4 participants