Replace slow gerrit-rpm-packaging implementation with a better one #1288
Conversation
dirkmueller
force-pushed
the
new_gerrit
branch
2 times, most recently
from
35bd44d
to
035215d
Compare
| - openstack-upstream-gerrit-rpm-packaging-Master | ||
| - openstack-upstream-gerrit-rpm-packaging-Mitaka | ||
| - openstack-upstream-gerrit-rpm-packaging-Newton | ||
| - openstack-rpm-packaging-sles12-Master |
There was a problem hiding this comment.
I think we currently use sles12sp1, no?
There was a problem hiding this comment.
yeah, I didn't want to expose the sp level, since that is an implementation detail (same reason it is called -centos7 not -centos7.3).
| tar xf ${{lcrelease}}.tar.gz | ||
| gitcheckout=rpm-packaging-stable-${{lcrelease}} | ||
| else | ||
| rm -rf rpm-packaging-stable-${{lcrelease}} |
There was a problem hiding this comment.
looks wrong to remove stable while working with master
| templ = """ | ||
| <project name="%(project)s"> | ||
| <title>Autogenerated CI project</title> | ||
| <description></description> |
There was a problem hiding this comment.
Not sure if that info is available but it would be nice to backlink to the review.openstack.org review in the description. But not a must, just want to mention it here.
There was a problem hiding this comment.
yep, I had that problem as well. it is on todo for a later point in time when I have a spare minute.
|
|
||
| repository = """ | ||
| <repository name="SLE_12_SP1" rebuild="local" block="local" %(linkedbuild)s> | ||
| <path project="Cloud:OpenStack:Upstream:Master" repository="SLE_12_SP1"/> |
There was a problem hiding this comment.
Looks wrong to always use "Cloud:OpenStack:Upstream:Master". What about Newton and Mitaka?
There was a problem hiding this comment.
whopsie, that is outdated. updated with the current version
dirkmueller
force-pushed
the
new_gerrit
branch
3 times, most recently
from
70d124f
to
71abbaf
Compare
| import glob | ||
| import os | ||
| import platform | ||
| import pymod2pkg |
There was a problem hiding this comment.
flake8 via travis complains about missing newlines and wrong ordering here.
There was a problem hiding this comment.
and it is wrong on that..
dirkmueller
force-pushed
the
new_gerrit
branch
from
71abbaf
to
4632a48
Compare
dirkmueller
force-pushed
the
new_gerrit
branch
from
4632a48
to
36c267e
Compare
| print('Updating meta for ', project) | ||
| meta.close() | ||
|
|
||
| sh.osc('api', '-T', meta.name, '/source/%s/_meta' % project) |
There was a problem hiding this comment.
IMHO you can use a variant of https://github.com/openSUSE/osc-plugin-factory/blob/master/osclib/stagingapi.py#L527
There was a problem hiding this comment.
As we hit a build service DoS protection on the number of source links, the old method did not work anymore. Replace with a project-link based solution that only rebuilds affected packages (and their dependencies)
dirkmueller
force-pushed
the
new_gerrit
branch
from
36c267e
to
7c50dc8
Compare
As we hit a build service DoS protection on the number of source links,
the old method did not work anymore. Replace with a project-link based
solution that only rebuilds affected packages (and their dependencies)