Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imds ver #106

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Imds ver #106

merged 4 commits into from
Feb 23, 2024

Conversation

rjschwei
Copy link
Collaborator

  • Enable setting the IMDS version to use for instances via image attribute
  • Update tests
    • Also update the libec2uploadimg test to enable direct execution in case pytest doesn't play well
  • Switch the build for SLE 15 SP4 and later to use Python 3.11

This should not be merged with squash

The bumpversion config setup was not in sync with the actual version
Support the new --imds-support command line argument. This allows the user
to upload an image that will switch launched instances to the IMDS v2
implementation.
The AWS toolchain is moving to a Python 3.11 based build in SLE 15 SP4 and
later. Accomodate this change by updating the RPM dependencies and adjusting
the path to the interpreter.
Copy link
Contributor

@apozsuse apozsuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Flake8 is complaining about a couple things (we might want to disable E402 and E124 there?)

@rjschwei
Copy link
Collaborator Author

LGTM

Flake8 is complaining about a couple things (we might want to disable E402 and E124 there?)

DIdn't even notice. Thanks for pointing it out. flake8 issues fixed.

Copy link
Contributor

@smarlowucf smarlowucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merge we want to make sure a tag is cut for the new version.

ec2uploadimg Outdated Show resolved Hide resolved
Support the new --imds-support command line argument. This allows the user
to upload an image that will switch launched instances to the IMDS v2
implementation.
@rjschwei rjschwei merged commit 3a92af6 into master Feb 23, 2024
4 checks passed
@rjschwei rjschwei deleted the imdsVer branch February 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants