Add a check for an image to become 'available' #50
Conversation
This patch uses the AWS waiter to add a check to ec2publishimg to allow it to wait for an an image to become available before it publishes the image. This close SUSE-Enceladus#45
This patch uses the AWS waiter to add a check to ec2publishimg to allow it to wait for an an image to become available before it publishes the image. This close SUSE-Enceladus#45
…gutils into wait_for_image_avail
…gutils into wait_for_image_avail
…gutils into wait_for_image_avail
This patch uses the AWS waiter to add a check to ec2publishimg to allow it to wait for an an image to become available before it publishes the image. This close SUSE-Enceladus#45 Add a check for an image to become 'available' This patch uses the AWS waiter to add a check to ec2publishimg to allow it to wait for an an image to become available before it publishes the image. This close SUSE-Enceladus#45 Fix extra blank line
Found an extra line
There was a problem hiding this comment.
Looks good. Only suggestion is if you do a custom waiter here where the code does the state comparison you could have a guard clause on the possible failed state that would allow the loop to exit early.
An example where I did this in Mash https://github.com/SUSE-Enceladus/mash/blob/master/mash/services/replicate/ec2_job.py#L153. Although I have no count so this code could technically get into an infinite loop.
…gutils into wait_for_image_avail
I added some code here to check for other states that should be skipped immediately. see if this is acceptable |
This patch uses the AWS waiter to add a check to ec2publishimg to
allow it to wait for an an image to become available before it
publishes the image.
This close #45