Add confirm option to ec2removeimg, remove references to ec2publishimg #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjschwei
requested changes
Aug 13, 2020
KeithMnemonic
force-pushed
the
fix_arguments_in_ec2removeimg
branch
from
7d97b0b
to
3fadd5c
Compare
rjschwei
requested changes
Aug 14, 2020
KeithMnemonic
force-pushed
the
fix_arguments_in_ec2removeimg
branch
2 times, most recently
from
f4749fe
to
f25e8ba
Compare
This patch removes references to ec2publishimg that were artifacts leftover from the initial script creation. In addition, it also implements the --confirm option. This option was originally listed as --no-confirm and was never implemented. In order to not create a regression, the option was changed to --confirm. This keeps the original default behavior of not asking for a confirmation. Finally, some logging was changed to just print an error message when exiting and not a full Traceback.
KeithMnemonic
force-pushed
the
fix_arguments_in_ec2removeimg
branch
from
f25e8ba
to
60a204b
Compare
smarlowucf
reviewed
Aug 17, 2020
rjschwei
approved these changes
Aug 18, 2020
smarlowucf
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the references to ec2publishimg and updates them to ec2publishimg. It also implements the --confirm option. This option was originally listed as --no-confirm as was not implemented. In order to not create a regression, the option was changed to confirm and implemented. This keeps the original default behavior of not asking for a confirmation. In addtion, some Tracebacks were cleaned up that were triggered when a reguired argument was missing. Instead of the Traceback, the program exits with an error and an appropriate message.