Truncate image for list images for a provider and a given state #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guangyee
force-pushed
the
truncate_deleted_payload
branch
2 times, most recently
from
2baaa8a
to
3d518bf
Compare
mbelur
reviewed
May 15, 2024
rtamalin
reviewed
May 15, 2024
rtamalin
reviewed
May 15, 2024
To avoid going over the AWS lambda payload size, we need to truncate the payload when listing images for a provider and a given image state (i.e. deleted). The truncated images are based on the oldest deleted date.
guangyee
force-pushed
the
truncate_deleted_payload
branch
from
3d518bf
to
6ffcd72
Compare
rtamalin
approved these changes
May 15, 2024
There was a problem hiding this comment.
LGTM
My concern about a lack of clarity as to how the requirements.txt and test-requirements.txt versions were selected has been addressed. As to whether that is the best approach in the long run is a separate discussion we can address after this PR has been merged. ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid going over the AWS lambda payload size, we need to truncate the payload when listing images for a provider and a given image state (i.e. deleted). The truncated images are based on the oldest deleted date.
Also update requirements.txt and test-requirements.txt with the latest available versions for Python 3.6.15.