Sort all image queries by publishedon date #140
Conversation
jeremy-moffitt
force-pushed
the
sort_images_publishedon
branch
2 times, most recently
from
502ba60
to
22588c3
Compare
jeremy-moffitt
force-pushed
the
sort_images_publishedon
branch
3 times, most recently
from
dd7b4cb
to
765529f
Compare
jeremy-moffitt
force-pushed
the
sort_images_publishedon
branch
from
765529f
to
0f03ac1
Compare
There was a problem hiding this comment.
Got this error on line 573 while doing API sanity tests. TypeError: count() takes exactly one argument (0 given).
I think we need to change it to if len(images) == 0: since images is a list object.
There was a problem hiding this comment.
made the recommended change, though this has me a little nervous, not because of the len check... but because I didn't anticipate this would change the type of the images collection...
There was a problem hiding this comment.
This probably goes back to aggressively adding the .all() in all those previous cases.
Without the .all() the object returned is a list generator that and be used to render an actual list if needed, but it is also an SQLAlchemy query object that can have further query operations applied to it, including the count() method which would return a count of the number of entries in the query response. Once we actualised the query results into a Python list the count method is no longer allowed, and you need to use len() to obtain the length of the list.
jeremy-moffitt
force-pushed
the
sort_images_publishedon
branch
from
0f03ac1
to
afd1f89
Compare
jeremy-moffitt
force-pushed
the
sort_images_publishedon
branch
from
afd1f89
to
69f22e3
Compare
To ensure that images trimmed from oversized queries are the oldest ones, it is necessary to sort the image/state query by publishedon date. For consistency, sort the other image queries the same way.