Improve bci-init tests

[grisu48]

Improve the systemd tests for the bci-init container by adding multiple
new tests for boottime, journald, timedatectl, loginctl, hostnamectl.

Related ticket: https://progress.opensuse.org/issues/111054

[dcermak]

Looks pretty good, I've added a few suggestions.

I would additionally suggest that you use the pytestmark global variable to just skip this module with docker & systemd >= 248. and Please use the auto_container fixture instead of container. There's really no need to repeat the parametrize for every single test function 😉

[grisu48]

I don't know why the pipeline is complaining about the code not being black formatted, IMHO it is:

./format.sh --check
All done! ✨ 🍰 ✨
29 files would be left unchanged.

[dcermak]

Looks good, just a few nitpicks here and there

[dcermak]

I don't know why the pipeline is complaining about the code not being black formatted, IMHO it is:

./format.sh --check
All done! ✨ 🍰 ✨
29 files would be left unchanged.

purge your .tox directly and run tox -e format

[grisu48]

Yay, it doesn't complain about not being black formatted anymore 🥳

[jlausuch]

VRs in openQA with 4 archs:
https://openqa.suse.de/tests/overview?distri=sle&version=15-SP4&build=BCI_INIT_FELIX_TESTS

[dcermak]

@grisu48 please add tox -e format --check to your pre-push git hooks 😂

[dcermak]

One assertion doesn't look right to me, otherwise this is ready to be merged 💪

[jlausuch]

Good job :)

[dcermak]

Please run tox -e format

[grisu48]

Did that while you have been complaining ;-) Should be good now, after the pipeline passes

[dcermak]

@jlausuch @grisu48 the last pipeline (https://github.com/SUSE/BCI-tests/runs/6875884458?check_suite_focus=true) failed with:

E       AssertionError: Unexpected exit code 1 for CommandResult(command=b'systemd-analyze time', exit_status=1, stdout=None, stderr=b"\x1b[0;1;31mBootup is not yet finished (org.freedesktop.systemd1.Manager.FinishTimestampMonotonic=0).\x1b[0m\n\x1b[0;1;31mPlease try again later.\x1b[0m\n\x1b[0;1;31mHint: Use 'systemctl list-jobs' to see active jobs\x1b[0m\n")

This could result in a flaky test, but maybe we should add a HEALTHCHECK to init instead. WDYT?

[grisu48]

I will have a look at this. Let me have another look, I would like to not push tests with flanky results. Marking as draft until resolved.

[grisu48]

SUSE/BCI-dockerfile-generator#9 should indeed prevent race conditions where the system target has not yet been reached. Thanks for the improvement.

I've pushed the black formatted test run and think we can proceed with this PR.

[dcermak]

Could it be that you force pushed some of your improvements away? There's a bunch of print statements back in there

[grisu48]

Could it be that you force pushed some of your improvements away? There's a bunch of print statements back in there

Oh damn, the rebase did something weird. Part of the latest changes got removed. Let me check, something went horribly wrong here.

Happy Monday btw ☕

[grisu48]

Fixed. Please review again and sorry for the fuzz @dcermak

[dcermak]

You have to use Dict and not dict.

[dcermak]

Thank you!