Replace curl by requests

[grisu48]

Replace the curl utility by the python requests library to avoid another
host-dependency.

[clanig]

Thanks a lot for taking care of this!
If the option --retry-connrefused is removed, I assume it will exit with 7 if the service is not available and not retry any more.

Since I guess, waiting for the service to become ready is the reason for the retry attempts, it would be similar to run without any retries.

I would suggest to wrapping the command itself in an own custom retry logic, not using any of the retry functionality provided by curl itself.

Edit: I like the replacement with requests even better.

[clanig]

LGTM.

[dirkmueller]

this can be

+        assert "Welcome to nginx" in host.check_output(
+            f"curl -sf --retry 5 http://localhost:{host_port}/"

instead, which avoids the requests dependency (don#t really care either way)

[grisu48]

No preference either, @dcermak you pick.

[dirkmueller]

tests/test_ruby.py needs to be updated then with the same change.

[grisu48]

Let's first see what @dcermak picks.

[dirkmueller]

full tested patch

--- a/tests/test_nginx.py
+++ b/tests/test_nginx.py
@@ -1,5 +1,6 @@
 """This module contains the tests for the nginx container, the image with nginx pre-installed.
 """
+from tenacity import retry, stop_after_delay
 from bci_tester.data import NGINX_CONTAINER
 
 
@@ -10,6 +11,9 @@ def test_nginx_welcome_page(auto_container, host):
     """test that the default welcome page is served by the container."""
     host_port = auto_container.forwarded_ports[0].host_port
 
-    assert "Welcome to nginx" in host.check_output(
-        f"curl -sf --retry 5 --retry-connrefused http://localhost:{host_port}/"
-    )
+    @retry(stop=stop_after_delay(10))
+    def check_nginx_response():
+        assert "Welcome to nginx" in host.check_output(
+            f"curl -sf --retry 5 http://localhost:{host_port}/"
+        )
+    check_nginx_response()
diff --git a/tox.ini b/tox.ini
index 290d137..880cf2e 100644
--- a/tox.ini
+++ b/tox.ini
@@ -10,6 +10,7 @@ deps =
     pytest-xdist ; python_version >= "3.6"
     dataclasses ; python_version < "3.7"
     pytest-rerunfailures
+    tenacity
     typing_extensions
     git+https://github.com/dcermak/pytest_container
     doc: Sphinx