qa: add openstack functional test to CI #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't initially delete the openstack pools, it means QA infra can pre-create these pools with the right number of PGs for the test environment. Fixes: #1322 Signed-off-by: Tim Serong <tserong@suse.com>
smithfarm
approved these changes
Sep 5, 2018
|
@tserong In the interests of expediency, I pushed the related qa changes into this PR. |
smithfarm
reviewed
Sep 5, 2018
qa/common/pool.sh
Outdated
| @@ -42,6 +42,7 @@ function pre_create_pools { | |||
| sleep 10 | |||
| POOLS="write_test" | |||
| test "$MDS" && POOLS+=" cephfs_data cephfs_metadata" | |||
| test "$OPENSTACK" && POOLS+=" smoketestcloud-backups smoketestcloud-volumes smoketestcloud-images smoketestcloud-vms" | |||
There was a problem hiding this comment.
@tserong Prefix is set to "smoketest" in the functests right?
smithfarm
force-pushed
the
wip-openstack-no-initial-clean
branch
from
27f83a5
to
023873e
Compare
|
@susebot run teuthology |
smithfarm
force-pushed
the
wip-openstack-no-initial-clean
branch
2 times, most recently
from
66575e5
to
550653a
Compare
|
Commit 023873e is NOT OK for suite suse:tier1. |
|
@susebot run teuthology |
|
Commit 550653a is NOT OK for suite suse:tier1. |
Use this option when running ceph.functests.1node.openstack, to pre-create the pools it needs. Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Fixes: #1349 Signed-off-by: Nathan Cutler <ncutler@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
smithfarm
force-pushed
the
wip-openstack-no-initial-clean
branch
from
5e743d9
to
349b7c0
Compare
|
@susebot run teuthology |
|
Commit 349b7c0 is NOT OK for suite suse:tier1. |
|
@tserong So, I now have a test (not merged yet) which deploys the testing cluster with pre-creation of the following pools:
However, ceph.functests.1node.openstack still fails because it tries to create pools without the prefix: Is that expected? Should I pre-create the non-prefixed pools as well? Note: this is not the test ran via the "susebot" comment(s) above. I ran it in a different teuthology instance. The whole log is: http://149.202.174.223/ubuntu-2018-09-05_12:51:14-suse:tier1-ses6---basic-openstack/60/teuthology.log |
|
Yeah, we need to create the non-prefixed pools too; srv/salt/ceph/functests/1node/openstack/init.sls tries to do both prefixed and non-prefixed pools, to ensure both paths succeed. |
|
Note: once the openstack functests are passing, I have a SUSE/ceph.git wip branch - https://github.com/SUSE/ceph/tree/wip-qa-openstack - that needs to be merged together with this PR. |
Signed-off-by: Nathan Cutler <ncutler@suse.com>
Test result: PASS |
smithfarm
changed the title
|
backport: #1354 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't initially delete the openstack pools, it means QA infra
can pre-create these pools with the right number of PGs for the test
environment.
Fixes: #1322
Signed-off-by: Tim Serong tserong@suse.com