RBD exporter fix volume snapshot duplicated metrics #1540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
can you have a look at this @jan--f ? |
|
@susebot run teuthology |
|
Commit f0df8ec is OK for suite suse:tier1. |
|
This still needs approval from @jan--f since I have no clue if this has any kind of sideeffects |
|
Sorry @y4ns0l0 for the long lag :( Can you add the new metrics output in comment please? |
|
So sorry guys 😕 but due to a job change I no longer have access to this ceph cluster. Keep up the great work! 😣 |
ok, good luck in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1539
Description: add label "snapshot" for volume snapshot