Fix runner parameter names in newer salt version (Boron) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jan--f Can you test this please. |
theanalyst
suggested changes
Nov 25, 2016
| """ | ||
| Check a cluster for runtime configurations that may cause issues for an | ||
| installation. | ||
| """ | ||
| if name == None: | ||
| name = kwargs['name'] | ||
| if cluster_name == None: |
There was a problem hiding this comment.
let's make this cluster_name is None
rjfd
force-pushed
the
wip-fix-boron-runner-param-error
branch
from
12acf22
to
41bb8d4
Compare
|
Works for me under salt 2016.3.4 (Boron). @supriti can you check if it works for you now too please. Maybe just 'cluster' would be better as the parameter? This would keep things consistent with the pillar data in DeepSea. |
|
@jan--f you're right. Will change it to |
The first parameter of a runner function cannot be named "name", as it is used internally by salt. Fixes: #50 Signed-off-by: Ricardo Dias <rdias@suse.com>
rjfd
force-pushed
the
wip-fix-boron-runner-param-error
branch
from
41bb8d4
to
b316da1
Compare
|
@jan--f pushed the rename changes. Might be worth to test again to check if I didn't screwed up anything the with the rename. |
theanalyst
reviewed
Nov 28, 2016
jan--f
approved these changes
Nov 28, 2016
theanalyst
approved these changes
Nov 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first parameter of a runner function cannot be named "name",
as it is used internally by salt.
Fixes: #50
Signed-off-by: Ricardo Dias rdias@suse.com