Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

bsc#1117942: fixes for volume plugins #724

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

inercia
Copy link
Contributor

@inercia inercia commented Feb 8, 2019

  • Use a writable directory for volume plugins
  • Use the same volumes plugins directory for the controller-manager and the kubelet

bsc#1117942

@inercia inercia force-pushed the custom_vol_plugin_dir branch 2 times, most recently from 5cd02ed to cc24be6 Compare February 8, 2019 17:19
Use the same volumes plugins directory for the controller-manager and the kubelet.

bsc#1117942

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>
@inercia inercia changed the title [WIP] Fixes for volume plugins Fixes for volume plugins Feb 11, 2019
@inercia inercia changed the title Fixes for volume plugins bsc#1117942: fixes for volume plugins Feb 13, 2019
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might choose better name then just volume? E. G is this only for cloud stuff? Otherwise looks ok

@spiarh
Copy link
Contributor

spiarh commented Feb 13, 2019

@MalloZup this is not specific to cloud, it is used to configure flexvolume drivers.

I'm currently testing it

Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flexvolume? maybe be better otherwise look good. When i hear volume i think on libvirt volumes or docker but yop ok

@spiarh
Copy link
Contributor

spiarh commented Feb 14, 2019

@r0ckarong we've fixed this issue but we're not using the default path because it points to a RO mountpoint, so this would need a point in documentation just to explain what is the good path ;)

  • Install FlexVolume drivers on CaaSP

A FlexVolume driver is an external (out of tree) driver usually provided by a specific Vendor.

These volume drivers have to be installed on each node (worker/master) in a Kubernetes cluster.

On SUSE CaaSP the path to install these drivers is /var/lib/kubelet/plugins.

Doc: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-storage/flexvolume.md

@spiarh
Copy link
Contributor

spiarh commented Feb 14, 2019

@inercia we need to backport this one ;)

@r0ckarong
Copy link

@lcavajani Is the documentation you linked applicable to CaaSP like that? If not could someone please provide the CaaSP specific steps.

Also, which version of CaaSP will receive this functionality? Is this going to be backported to v3?

@inercia inercia merged commit 7835bd8 into master Feb 14, 2019
@inercia inercia deleted the custom_vol_plugin_dir branch February 14, 2019 16:28
@spiarh
Copy link
Contributor

spiarh commented Feb 15, 2019

@r0ckarong this will be backported to v3 yes.

There is no specific configuration to do for CaaSP afterwards.

These drivers are usually deployed with DaemonSets, what the user should do is to change the value of the flexolume dir path in the manifests which is usually in the form of an environment variable (e.g FLEXVOLUME_DIR_PATH for rook [1])

[1] https://rook.io/docs/rook/v0.9/flexvolume.html#configuring-the-flexvolume-path

@r0ckarong
Copy link

r0ckarong commented Feb 28, 2019

so this would need a point in documentation just to explain what is the good path ;)

What is this better path?

@spiarh
Copy link
Contributor

spiarh commented Feb 28, 2019

@r0ckarong the path is /var/lib/kubelet/plugins

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants