Run basic hwinfo sanity test on build service

[djoreilly]

A test flag is added so the build service will run this test on
the x86, ARM and s390 builds. The flag is off by default so it does
not run on developers machines.

[djoreilly]

From the x86 build log

[  109s] === RUN   TestGetHwinfo
[  109s]     hwinfo_test.go:134: getHwinfo() failed: ExecuteError: Cmd: [dmidecode -s system-uuid], RC: -1, Error: exec: "dmidecode": executable file not found in $PATH, Output: 
[  109s] --- FAIL: TestGetHwinfo (0.02s)

Dmidecode is in the build requires. Maybe /usr/sbin is not in $PATH

[skazi0]

Dmidecode is in the build requires. Maybe /usr/sbin is not in $PATH

I see it only in Requires not in BuildRequires. I'll try to add it there but I first want to add the error handling as in the original.

[djoreilly]

Dmidecode is in the build requires. Maybe /usr/sbin is not in $PATH

I see it only in Requires not in BuildRequires. I'll try to add it there but I first want to add the error handling as in the original.

ah okay. Sounds like a good plan. Thanks

[JanZerebecki]

We were talking about running hwinfo here failing on OBS because it is running as a user, but accessing /dev/mem needs root.

There is a way to give builds access to root, but that needs whitelisting by an obs admin, so we should not use it:
https://github.com/openSUSE/open-build-service/blob/af9297d8d8fb79e14951f657a792474c53179e67/src/backend/BSConfig.pm.template#L220

So, no good way to do tests during rpm build that need root. So if that is the only way then it needs to happen in some other CI, like openqa. The openqa tests are currently run against MicroOS on s390, aarch64 and x86_64.

[djoreilly]

ok, so maybe the build service should not run with-test-hwinfo and instead do this test as root on openqa instead. Or maybe there is some env var that can be checked to determine if the tests are running openqa, or maybe we could just skip the hwinfo test if os.Geteuid() != 0

[skazi0]

if we add this check, the test will most probably not be run anywhere.
I have another idea: add some macro "flag" in the spec file and make those tests conditional on that. This way we can branch the package, set this flag and get at least the non-root parts executed if needed. These tests have proven useful already and detected missing PPC implementation so I'd rather keep them around at least for manual run.

[djoreilly]

ok, so maybe the build service should not run with-test-hwinfo and instead do this test as root on openqa instead. Or maybe there is some env var that can be checked to determine if the tests are running openqa, or maybe we could just skip the hwinfo test if os.Geteuid() != 0

[djoreilly]

LGTM - but I'm not allowed to approve because I started the PR.

[skazi0]

@JanZerebecki can you take a quick look at the spec file changes?

[JanZerebecki]

I don't have time to look at it in detail, you will need to proceed without me. There are people outside of our team who have knowledge of openqa who you can contact, e.g. Jose username jlausuch on Github.

[skazi0]

@JanZerebecki thx!