Switch from rubygem-ffi to fiddle #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fiddle is an FFI implementation which is included in standard Ruby. Switching from FFI gem to Fiddle removes one dependency without loosing any functionality.
lslezak
approved these changes
Jan 7, 2022
| dlload 'libsuseconnect.so' | ||
| typealias 'string', 'char*' | ||
|
|
||
| #callback type: void log_line(int, string) |
There was a problem hiding this comment.
If it is not needed then I'd remove it completely, avoid dead code...
There was a problem hiding this comment.
This is not old code, just a plain comment. Fiddle doesn't support callback types so everything is passed as void pointer. Without this, future us would need to dig through the code to find out what is the expected function signature.
There was a problem hiding this comment.
Ah, I overlooked that, I thought it is part of the previous ffi code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fiddle is an FFI implementation which is included in standard Ruby.
Switching from FFI gem to Fiddle removes one dependency without loosing
any functionality.