Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate free() calls back to Go (bsc#1195729) #121

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

skazi0
Copy link
Contributor

@skazi0 skazi0 commented Feb 10, 2022

Direct import from libc causes problems when custom malloc
implementation like jemalloc is used. Passing the pointer back to Go
seems to be the safest way to handle memory management as both
allocation and freeing is done on the same side and there is no explicit
imports.

Direct import from libc causes problems when custom malloc
implementation like jemalloc is used. Passing the pointer back to Go
seems to be the safest way to handle memory management as both
allocation and freeing is done on the same side and there is no explicit
imports.
Copy link
Collaborator

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skazi0 skazi0 merged commit d7b2b43 into SUSE:main Feb 10, 2022
@skazi0 skazi0 deleted the freego branch February 10, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants