go1.18 compatibility: export GOFLAGS="-buildvcs=false" #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skazi0
suggested changes
Apr 13, 2022
|
Maybe instead we can rm -rf .git in %prep. |
jfkw
force-pushed
the
SUSE#128-go1.18-buildvcs-git-softdep
branch
from
091a536
to
29b8399
Compare
or add git to BuildRequires? I think either way would be cleaner |
* go1.18+ detects VCS e.g. .git in sources https://go.dev/doc/go1.18#go-version * Default behavior -buildvcs=auto calls git to embed build info
JanZerebecki
force-pushed
the
SUSE#128-go1.18-buildvcs-git-softdep
branch
from
29b8399
to
7497adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to RPM spec file for go1.18 compatibility: export GOFLAGS="-buildvcs=false" in sections %build and %check.
Closes #128.
After go1.18.1 a follow-up PR to #128 will remove the export in %check (go test).