Added support for the System-Token header #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skazi0
reviewed
Jul 20, 2022
In order to detect system duplicates, SCC implemented a `System-Token` mechanism in which systems are to report a token that is generated for every request from systems. The Ruby implementation of SUSEConnect stores this into the credentials file for every request. If the response did not contain any token (e.g. first time that a system contacts SCC or upgrading from and older SUSEConnect) then an empty token is stored into the credentials file. All in all, this commit brings this Go implementation on par with the Ruby one when it comes to detecting system duplicates. Fixes #125 Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola
force-pushed
the
add-system-token-header-support
branch
from
b5526ad
to
0310a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to detect system duplicates, SCC implemented a
System-Tokenmechanism in which systems are to report a token that is generated for every request from systems.The Ruby implementation of SUSEConnect stores this into the credentials file for every request. If the response did not contain any token (e.g. first time that a system contacts SCC or upgrading from and older SUSEConnect) then an empty token is stored into the credentials file. All in all, this commit brings this Go implementation on par with the Ruby one when it comes to detecting system duplicates.
How to test this
--keepalivecommand)system_tokenvalue.system_tokencolumn.Retry steps 2, 3 and 4 multiple times and check that the
system_tokenfield keeps being in sync.Related issues
Fixes #125