-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deactivate API to ruby bindings (bsc#1202705) #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is what we need in YaST, thank you!
Just let me know in which version it will be released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a way to test this, to be honest, but it looks good code-wise.
@djoreilly you are also listed as a reviewer on this, could you take a look? Thanks!
Here's how I tested this. Downloaded rpms with browswer from https://build.opensuse.org/package/binaries/home:jzerebecki:CI:target:SUSE:connect-ng:PR-153/suseconnect-ng/openSUSE_Leap_15.3 mkdir /tmp/rpms docker run -it -v /tmp/rpms:/rpms --name test-pr153 registry.suse.com/bci/bci-base bash
|
Existing functionalities used by CLI were exposed and can be called from ruby clients. Closes SUSE#148
c72c299
to
cc2ee07
Compare
Is there a reason for this not being merged yet? |
no - it just needed some reviews. I think it's okay to merge now. |
Thank you! 👍 |
Existing functionalities used by CLI were exposed and can be called from ruby clients.
Closes #148