Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keepalive on SUMA systems exit without error #167

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

djoreilly
Copy link
Collaborator

The keepalive option is called from a systemd timer. It is expected to fail on SUMA systems, so there is no need to to spam the logs. bsc#1207876

@digitaltom
Copy link
Member

Thanks for the fix! Could you please add a reference to the changelog with the bug?

The keepalive option is called from a systemd timer. It is expected
to fail on SUMA systems, so there is no need to to spam the logs.
@djoreilly
Copy link
Collaborator Author

Thanks for the fix! Could you please add a reference to the changelog with the bug?

I moved bsc#1207876 to the first line of the commit message. It should end up in the changes file.

https://build.opensuse.org/package/view_file/systemsmanagement:SCC/suseconnect-ng/suseconnect-ng.changes?expand=1

Copy link
Collaborator

@JanZerebecki JanZerebecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this still allows a user to use all the other commands, which is probably OK. Looks good, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants