Don't send unneeded Product fields to API #75
Conversation
internal/connect/product.go
Outdated
| Summary string `xml:"summary,attr" json:"-"` | ||
| IsBase bool `xml:"isbase,attr" json:"-"` | ||
| IsBase bool `xml:"isbase,attr" json:"base"` |
There was a problem hiding this comment.
was changing the json tag intentional?
There was a problem hiding this comment.
it was but not for this PR :o)
removed.
|
This is more to match our payloads to API spec and original client than to save bandwidth. |
internal/connect/api.go
Outdated
| @@ -75,7 +75,7 @@ func showProduct(productQuery Product) (Product, error) { | |||
| func upgradeProduct(product Product) (Service, error) { | |||
| // NOTE: this can add some extra attributes to json payload which | |||
There was a problem hiding this comment.
can this comment be removed now?
internal/connect/api.go
Outdated
| @@ -130,7 +126,7 @@ func activateProduct(product Product, email string) (Service, error) { | |||
| func deactivateProduct(product Product) (Service, error) { | |||
| // NOTE: this can add some extra attributes to json payload which | |||
There was a problem hiding this comment.
can this comment be removed now?
| @@ -5,11 +5,17 @@ import ( | |||
| "strings" | |||
| ) | |||
|
|
|||
| // Product represents an installed product or product information from API | |||
| type Product struct { | |||
| // BasicProduct represents basic information on product, mostly for API requests | |||
There was a problem hiding this comment.
maybe this comment could also mention that BasicProduct is used instead of Product to avoid sending unneeded bool json or something
Product structure was split into two parts. BasicProduct with fields needed to identify the product and Product which embeds BasicProduct and adds more fields on top. For API calls which only need the basic fields, BasicProduct part can be used even if Product was passed.
|
We discussed this last week and decided the change is not necessary. Closing. |
Product structure was split into two parts. BasicProduct with fields
needed to identify the product and Product which embeds BasicProduct
and adds more fields on top.
For API calls which only need the basic fields, BasicProduct part can be
used even if Product was passed.