Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YaST integration #79

Merged
merged 43 commits into from
Nov 30, 2021
Merged

Add YaST integration #79

merged 43 commits into from
Nov 30, 2021

Conversation

skazi0
Copy link
Contributor

@skazi0 skazi0 commented Oct 14, 2021

No description provided.

@skazi0 skazi0 changed the title Add readme for YaST integration Add YaST integration Oct 14, 2021
@skazi0 skazi0 requested a review from djoreilly October 14, 2021 11:23
djoreilly
djoreilly reviewed Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@djoreilly djoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions. I still need to test from yast. Thanks for improving the Ruby side of this.

internal/connect/credentials.go Outdated Show resolved Hide resolved
libsuseconnect/libsuseconnect.go Show resolved Hide resolved
yast/lib/suse/connect/config.rb Outdated Show resolved Hide resolved
yast/README.md Outdated Show resolved Hide resolved
yast/lib/suse/connect/yast.rb Show resolved Hide resolved
yast/test.rb Outdated Show resolved Hide resolved
@skazi0 skazi0 force-pushed the yast-integration-poc branch 4 times, most recently from 501806b to 2783e38 Compare October 14, 2021 22:25
@skazi0
Copy link
Contributor Author

skazi0 commented Oct 14, 2021

rebased

@djoreilly djoreilly mentioned this pull request Oct 15, 2021
Closed
@skazi0 skazi0 force-pushed the yast-integration-poc branch 4 times, most recently from 7576c92 to 1023a23 Compare October 19, 2021 10:36
@skazi0 skazi0 force-pushed the yast-integration-poc branch 4 times, most recently from 0eea901 to 7bb214d Compare October 29, 2021 21:06
@skazi0 skazi0 requested a review from djoreilly November 3, 2021 15:53
djoreilly
djoreilly approved these changes Nov 9, 2021
View reviewed changes
internal/connect/connection.go Outdated Show resolved Hide resolved
djoreilly
djoreilly requested changes Nov 9, 2021
View reviewed changes
libsuseconnect/libsuseconnect.go Outdated Show resolved Hide resolved
@skazi0 skazi0 marked this pull request as ready for review November 9, 2021 21:12
@skazi0
Copy link
Contributor Author

skazi0 commented Nov 10, 2021

rebased to get package search in

@skazi0
Init defaults for get_config()
1b43c19
@skazi0
Improved SSL error handling
02787c4 
Some additional mapping of Go SSL errors to OpenSSL ones expected by
YaST. This should correctly trigger custom dialogs implemented in YaST
registration and enable automatic import functions for untrusted certs.
@skazi0
Add more specific errors
bf4e0ba 
Added handling for JSON, Net and Timeout errors expected by YaST.
@skazi0
Add "update certificates"
74883a3 
To avoid redundant implementation of execute(), calling
update-ca-certificates was delegated to Go.
@skazi0
Add list_installer_updates
112c6e3 
Also extend Repo structure with all fields from API docs.
Add release_type to Product.toQuery() to match original.
@skazi0
Add missing JSONError
8d94b83 
Some Unmarshal() calls didn't have the error wrapped correctly.
@skazi0
Fix handling of IsBase attribute
97eab30 
Is-Base product information is handled differently in different
contexts. Extended unmarshaler joins information from different sources
into one attribute. Default "isbase" is reserved for YaST integration to
match original.
@skazi0
Add migration functions
1c84974 
Exported missing function required for migration scenario.
Also added "shortname" attribute to Product as it's used in the YaST UI.
@skazi0
Export SystemActivations()
90b207e
@skazi0
Export UpdateSystem()
ef4ca29
@skazi0
Clarify Repo fields
75b6feb
@skazi0
Add package search for YaST's "Online Search"
164dce6
@skazi0
Enable debug early
33ed45c 
Some debug messages from config parsing were not forwarded to YaST
logger.
@skazi0
Removed TODO item handled separately
c6657d6
@skazi0
Fix logger crash and restore mixin
e11e133 
Fixed crash when using uninitialized logger function.
Also restored original Logger mixin to make it easier to use logging in
the shim.
@skazi0
Fix SSLCertificate mixins
898c4b7 
SSLCertificate uses only class methods so it requires extend instead of
include for mixins to work correctly.
@skazi0
Align with yast-registration tests
f4bccdb 
Added Dockerfile which can be used to run original yast-registration
tests with libsuseconnect and shim injected.
Modified curlrc handling to match original behavior of ignoring errors.
@skazi0
Package libsuseconnect and shim
615be86 
RPM spec file was updated to build libsuseconnect and
suseconnect-ruby-bindings subpackages.
In addition spec file got some minor cleanups and tweaks.
@skazi0
Post-review cleanup
0bd59ad
@skazi0
Add versions and lib deps
aa47edd 
Shared library needs the same dependencies as CLI and while it doesn't
require the CLI iteself it's easier to "Requires" suseconnect-ng to get
all dependencies indirectly.
Additional benefit is that suseconnect-ng will always be installed when
switching from old (Ruby) version to the new one.
@skazi0
Copy link
Contributor Author

skazi0 commented Nov 30, 2021

rebased to pull package-search in

JanZerebecki
JanZerebecki approved these changes Nov 30, 2021
View reviewed changes
Copy link
Collaborator

@JanZerebecki JanZerebecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the spec file, Makefile, and Dockerfiles. Those look good.

@skazi0 skazi0 merged commit 296ab4a into SUSE:main Nov 30, 2021
@skazi0 skazi0 deleted the yast-integration-poc branch November 30, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djoreilly djoreilly djoreilly approved these changes

@JanZerebecki JanZerebecki JanZerebecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skazi0 @JanZerebecki @djoreilly