Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoYaST whole disk and partitioned software RAIDs #352

Closed
wants to merge 9 commits into from
Closed

AutoYaST whole disk and partitioned software RAIDs #352

wants to merge 9 commits into from

Conversation

imobachgs
Copy link
Member

For SLE 15 SP1 it will possible to use a whole disk as a filesystem or as part of a LVM or a software RAID. Additionally, we have introduced support for partitioned RAIDs.

However, these features will be available for SLE 15 SP0 using the installer self-update functionality and I am not sure about how to reflect that in the documentation. Please, have a look when you have time. Feedback is welcome.

Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imobachgs : Many thanks for the PR! Looks mostly fine to me.

However, already mentioning SLE 15 SP1 already does not make sense yet, because in 'develop', we are currently still working on SLE 15. (Therefore I moved one of the sentences into a remark, where it does not appear for SLE 15 yet, but we can enable it as soon as we have created a 'maintenance/SLE15' branch and switched to SLE 15 SP1 in 'develop').

I suggested some more small changes (mostly style guide-triggered or to avoid ambiguities). If you do not want to fix them yourself, please review them and let us know if you are fine with the changes, then we will incorporate them when merging the PR. Many thanks!

xml/ay_bigfile.xml Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
<para>
The following example shows a simple RAID1 configuration:
The following example shows a RAID1 configuration using a partition from the first disk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using -> that uses (to prevent ambiguity)

xml/ay_bigfile.xml Outdated Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
xml/ay_bigfile.xml Show resolved Hide resolved
xml/ay_bigfile.xml Outdated Show resolved Hide resolved
@taroth21 taroth21 added the WIP label Nov 5, 2018
@imobachgs
Copy link
Member Author

@taroth21 : thanks a lot for your feedback! No problem, I will take care of fixing the PR.

taroth21 and others added 6 commits November 22, 2018 16:42
Co-Authored-By: imobachgs <imobachgs@gmail.com>
Co-Authored-By: imobachgs <imobachgs@gmail.com>
Co-Authored-By: imobachgs <imobachgs@gmail.com>
Co-Authored-By: imobachgs <imobachgs@gmail.com>
@imobachgs
Copy link
Member Author

Hi @taroth21. I have fixed the mentioned issues (I hope I have not introduced new ones 😄).

@taroth21
Copy link
Contributor

Closing unmerged - please see #376 to continue.

@taroth21 taroth21 closed this Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants