Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring logic to aws #203

Merged
merged 7 commits into from
Sep 30, 2019
Merged

Add monitoring logic to aws #203

merged 7 commits into from
Sep 30, 2019

Conversation

ayoub-belarbi
Copy link
Contributor

@ayoub-belarbi ayoub-belarbi commented Sep 26, 2019 •
edited

  • Enable monitoring for AWS
  • Add the option to enable/disable monitoring for AWS

@ayoub-belarbi ayoub-belarbi added the WIP Work in Progress label Sep 26, 2019
@ayoub-belarbi ayoub-belarbi changed the title add monitoring logic to aws [wip] add monitoring logic to aws Sep 26, 2019
MalloZup
MalloZup reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@MalloZup MalloZup left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far ( considering it is a WIP)

@ayoub-belarbi ayoub-belarbi changed the title [wip] add monitoring logic to aws Add monitoring logic to aws Sep 30, 2019
@ayoub-belarbi ayoub-belarbi removed the WIP Work in Progress label Sep 30, 2019
@ayoub-belarbi
Add support for the enable/disable feature
131d79c 
Fix outputs.tf

Fix outputs.tf formating

Fix terraform fmt checks
MalloZup
MalloZup approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm to me. Review my pr now 😉 wait for others pov on this but looks good

juadk
juadk reviewed Sep 30, 2019
View reviewed changes
Copy link
Contributor

@juadk juadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking good to me, test are in progress.

aws/terraform.tfvars.example Outdated Show resolved Hide resolved
@ayoub-belarbi @juadk
Update aws/terraform.tfvars.example
10db1c7 
Co-Authored-By: Julien ADAMEK <julien.adamek@suse.com>
@juadk juadk self-requested a review September 30, 2019 13:32
juadk
juadk approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@juadk juadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS is working well (qa_mode: true) with or without monitoring part, thx!

arbulu89
arbulu89 approved these changes Sep 30, 2019
View reviewed changes
Copy link
Collaborator

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! It looks great and following same convention than Azure.
Thanks!

aws/instances.tf

resource "aws_instance" "monitoring" {
count = var.monitoring_enabled == true ? 1 : 0
ami = var.sles4sap[var.aws_region]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces the usage of SLE15 only, just a reminder...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not when monitoring is disabled, no?

@ayoub-belarbi ayoub-belarbi merged commit 50cbaa5 into SUSE:master Sep 30, 2019
@MalloZup MalloZup mentioned this pull request Oct 1, 2019
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldevulder ldevulder ldevulder left review comments

@juadk juadk juadk approved these changes

@MalloZup MalloZup MalloZup approved these changes

@arbulu89 arbulu89 arbulu89 approved these changes

@diegoakechi diegoakechi Awaiting requested review from diegoakechi

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ayoub-belarbi @juadk @MalloZup @ldevulder @arbulu89