Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated function #40

Merged
merged 2 commits into from
Feb 12, 2019
Merged

Update deprecated function #40

merged 2 commits into from
Feb 12, 2019

Conversation

juadk
Copy link
Contributor

@juadk juadk commented Feb 12, 2019 •
edited by alvarocarvajald
Loading

  • Update deprecated public_ip_address_allocation in favor of allocation_method in Azure configuration files.
    Link for upstream PR about this change

@juadk
Update deprecated function
798a4be 
* deprecated public_ip_address_allocation in favor of allocation_method
@juadk
Terraform fmt needed for Travis check
423edde
alvarocarvajald
alvarocarvajald approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ricardobranco777
ricardobranco777 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldevulder
ldevulder approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@ldevulder ldevulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldevulder ldevulder merged commit 189bdbb into SUSE:master Feb 12, 2019
@juadk juadk deleted the update_deprecated_function branch February 14, 2019 10:41
arbulu89 pushed a commit to arbulu89/ha-sap-terraform-deployments that referenced this pull request Mar 20, 2019
@ldevulder
Merge pull request SUSE#40 from juadk/update_deprecated_function
9882e19 
Update deprecated function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

@ldevulder ldevulder ldevulder approved these changes

@alvarocarvajald alvarocarvajald alvarocarvajald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juadk @ricardobranco777 @ldevulder @alvarocarvajald