Issue 94 #100
Closed
Issue 94 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for episode model
Project sorting
Use correct timestamp for "Last updated" text on projects overview page (issue SUSE#62)
| end | ||
|
|
||
| @project.join! current_user | ||
| redirect_to project_path(@episode, @project), notice: "Welcome to the project #{current_user.name}!" | ||
| if @project.users.include?(current_user) |
There was a problem hiding this comment.
It's not possible via the interface to join twice (except if you mess with the js). I think it would be better if we just discard this case without a flash or anything
There was a problem hiding this comment.
It is. One way would be to change the html, the other one is to click twice fast enough.
I guess that's what happened to vojtech: https://hackweek.suse.com/11/projects/256
btw I used :notice here because :error did not seem to work
|
@hennevogel I removed the controller part. |
|
We reverted to UI... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.