Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown preview #121

Merged
merged 12 commits into from
Mar 31, 2015
Merged

Markdown preview #121

merged 12 commits into from
Mar 31, 2015

Conversation

kirushik
Copy link
Contributor

Closes #91

Opens previews in a modal popup window.
Works via javascript and AJAX.
Should be more or less covered by tests (and that coverage is easy to extend in case of bugs).

Currently only bound to Project description form field, but should be pretty easy to attach to other forms/fields as well.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.49%) to 78.86% when pulling dd72583 on kirushik:markdown_preview into 98d1b49 on SUSE:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.49%) to 78.86% when pulling 982bfc8 on kirushik:markdown_preview into 98d1b49 on SUSE:master.

@kirushik kirushik assigned bkutil and unassigned hennevogel and bkutil Mar 27, 2015
@hennevogel
Copy link
Member

Sorry this week was crazy for me. I don't like the interface very much, why don't you put it into a tab? Like in the comment field here. That would be great :-)

@kirushik
Copy link
Contributor Author

@hennevogel OK, I can move that into tab. Will update this PR tommorow, then.

Are you OK with server-side rendering approach in general? I've chosen that over the clientside javascript rendering libraries, mostly because this way we can be as close as possible to the actual rendering outcome.

@kirushik
Copy link
Contributor Author

I will reopen this PR when new interface will be ready.

@kirushik kirushik closed this Mar 30, 2015
@hennevogel
Copy link
Member

@kirushik server side rendering is cool :-)

@kirushik
Copy link
Contributor Author

@hennevogel OK, now there are tabs.

@kirushik kirushik reopened this Mar 30, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 78.37% when pulling 4ef9149 on kirushik:markdown_preview into af11a92 on SUSE:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 78.37% when pulling 4ef9149 on kirushik:markdown_preview into af11a92 on SUSE:master.

hennevogel added a commit that referenced this pull request Mar 31, 2015
@hennevogel hennevogel merged commit 4562eb6 into SUSE:master Mar 31, 2015
@kirushik kirushik deleted the markdown_preview branch March 31, 2015 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing a preview mode for markdown-accepting textareas
4 participants