Developer bootstrap improvements #161

purp · 2017-02-15T15:27:58Z

Just a rake task to bootstrap a new developer environment.

The sqlite example won’t work in development due to dependencies on ThinkingSphinx, which doesn’t support sqlite3. The vagrant example works fine in non-vagrant setups.

Add rake task to bootstrap dev setup. * Copy config examples in place * Perform bundle:install * Check for Sphinx install * generate Sphinx configs (via ThinkingSphinx) * generate Sphinx indices

purp · 2017-02-15T16:22:12Z

Working on fixing travis-ci. Will update shortly.

coveralls · 2017-02-15T20:49:15Z

Coverage remained the same at 78.817% when pulling 07c2900 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

Not needed for travis-ci anymore

Allows `travis lint` for checking travis config

coveralls · 2017-02-15T21:14:02Z

Coverage remained the same at 78.817% when pulling dddf262 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

Cleans up deprecation: DEPRECATION WARNING: You are passing an instance of ActiveRecord::Base to `find`. Please pass the id of the object by calling `.id`. (called from load_episode at /home/travis/build/SUSE/hackweek/app/controllers/projects_controller.rb: 207)

Cleans up deprecation: DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /home/travis/build/SUSE/hackweek/app/assets/stylesheets/strap-on.css.scs s to /home/travis/build/SUSE/hackweek/app/assets/stylesheets/strap-on.scss. (called from _app_views_projects_show_html_haml___2150580354090734029_98454160 at /home/travis/build/SUSE/hackweek/app/views/projects/show.html.haml:16) DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /home/travis/build/SUSE/hackweek/app/assets/stylesheets/zoomed.css.scss to /home/travis/build/SUSE/hackweek/app/assets/stylesheets/zoomed.scss. (called from _app_views_projects_show_html_haml___2150580354090734029_98454160 at /home/travis/build/SUSE/hackweek/app/views/projects/show.html.haml:16) DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /home/travis/build/SUSE/hackweek/app/assets/stylesheets/strap-on.css.scs s to /home/travis/build/SUSE/hackweek/app/assets/stylesheets/strap-on.scss. (called from _app_views_projects_show_html_haml___2150580354090734029_98454160 at /home/travis/build/SUSE/hackweek/app/views/projects/show.html.haml:16) DEPRECATION WARNING: Extra .css in SCSS file is unnecessary. Rename /home/travis/build/SUSE/hackweek/app/assets/stylesheets/zoomed.css.scss to /home/travis/build/SUSE/hackweek/app/assets/stylesheets/zoomed.scss. (called from _app_views_projects_show_html_haml___2150580354090734029_98454160 at /home/travis/build/SUSE/hackweek/app/views/projects/show.html.haml:16)

Gets all the rest of these: DEPRECATION WARNING: You are passing an instance of ActiveRecord::Base to `find`. Please pass the id of the object by calling `.id`. (called from load_episode at /Users/purp/Library/Mobile Documents/com~apple~CloudDocs/purp/work/hackweek/app/controllers/project s_controller.rb:207)

Depreciation cleanups

hennevogel · 2017-02-16T13:33:31Z

.travis.yml

@@ -10,10 +12,13 @@ notifications:
    on_failure: change
 before_install:
  - "echo 'gem: --no-ri --no-rdoc' > ~/.gemrc"
-before_script: 
+  - mysql -e 'CREATE DATABASE hackweek_test;'


bundle exec rake db:create

Agree that should work. I was following the recommendation from the Travis CI docs for MySQL with ActiveRecord. Will change to bundle exec

hennevogel · 2017-02-16T13:36:09Z

.travis.yml

-  - RAILS_ENV=test bundle exec rake db:migrate --trace  
+  - RAILS_ENV=test bundle exec rake db:migrate --trace
+env:
+  - TRAVIS=true


travis sets this automatically -> https://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables

Ha! I missed that, and "invented" my own. Will change.

hennevogel · 2017-02-16T13:37:00Z

Gemfile

@@ -73,6 +72,8 @@ gem 'capybara', :group => [:development, :test]
 gem 'paperclip', '~> 4.1'
 # as interactive debugger in error pages
 gem 'web-console', '~> 2.0', group: :development
+# Help with travis config testing
+gem 'travis', :group => [:development, :test]


Too many dependencies just for a linter, we don't have to have this in the bundle I think.

Fair. I'll drop it.

hennevogel · 2017-02-16T13:41:05Z

lib/tasks/dev.rake

@@ -0,0 +1,51 @@
+# Don't add any includes that aren't in the Ruby std-lib here,


We already have the vagrant box and this is duplicating bootstrap.sh a lot. Too much for my taste, sorry.

I understand, and I'm not sure I see the duplication that you do.

The rake task intends to handle only Rails-oriented environment setup. It does five main things:

Copy required Rails config files into place

Install required Ruby gems using the bundle command

Set up the required databases for the Rails app (create, migrate, and seed)

Generate Sphinx configuration for the Rails app (first checking that Sphinx is installed)

Generate Sphinx indexes for the Rails app

When I look at bootstrap.sh, the only overlap I see between this rake task and bootstrap.sh is copying the proper database configuration file in place. Perhaps I'm not seeing other parts which overlap. Could you say more about this?

Meanwhile, I think we could separate concerns into two here:

Setting up the development machine (installing packages like mysql and sphinx, configuring the system, etc.) This should definitely be handled by bootstrap.sh for the OpenSUSE vagrant-based development environment.

Setting up the Rails app and Rails environment. This could be handled for all environments by the rake task here.

Doing this could DRY up a couple of things:

bootstrap.sh could call the rake task once the development machine setup is complete

We could replace the entire before_script section in travis.yml with bundle exec rake dev:bootstrap

I'm happy to extend this PR to cover those changes, as well as updating the README, if you agree with this direction.

That would be a way to make setting up in travis/vagrant more DRY yes.

However I'm not really convinced that we need to 'hide' away the standard rails env setup tasks from people. People are used to this, this is mentioned in documentation, tutorials etc. etc.

Let's do this for travis/vagrant and only mention this after the 'standard' steps like:

To make this more convenient for you we have setup a rake task that executes the above steps: bundle exec rake dev:boostrap

Okay? :-)

I like it. I'll update the PR this morning.

@hennevogel

As @hennevogel points out, this is a default set by Travis CI.

It adds a kerjillion dependencies.

`rake` is evidently not available on the system in `before_install`

coveralls · 2017-02-16T17:38:54Z

Coverage remained the same at 78.817% when pulling 18a5940 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

purp · 2017-02-17T13:41:30Z

That leads to an interesting failure that I can't reproduce locally. I'm going to ponder how to debug this a bit.

* Rails.root.join was overcomplicated * I forgot to include the actual copy command =\

coveralls · 2017-02-18T04:35:55Z

Coverage decreased (-0.2%) to 78.626% when pulling a0d1b05 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

coveralls · 2017-02-18T05:14:25Z

Coverage decreased (-0.2%) to 78.626% when pulling a319633 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

hennevogel · 2017-02-20T12:56:39Z

Fixed in 031482c

hennevogel · 2017-02-20T13:04:15Z

@purp anything left to do?

Add hackweek 15 intro video

The sqlite example won’t work in development due to dependencies on ThinkingSphinx, which doesn’t support sqlite3. The vagrant example works fine in non-vagrant setups.

Add rake task to bootstrap dev setup. * Copy config examples in place * Perform bundle:install * Check for Sphinx install * generate Sphinx configs (via ThinkingSphinx) * generate Sphinx indices

Not needed for travis-ci anymore

Allows `travis lint` for checking travis config

@hennevogel

As @hennevogel points out, this is a default set by Travis CI.

It adds a kerjillion dependencies.

`rake` is evidently not available on the system in `before_install`

* Rails.root.join was overcomplicated * I forgot to include the actual copy command =\

…/purp/hackweek into developer_bootstrap_improvements

purp · 2017-02-20T17:47:55Z

Updating to catch up with upstream master, then I'll see if your fix solves the vagrant filesystem mounting issue I saw. If so, I'll finish up changes to bootstrap.sh.

Incidentally, the filesystem was mounting when the VM started; I was able to verify via vagrant exec ls -l /vagrant while bootstrap was running. I was able to narrow it to before/after the zypper dup operation.

coveralls · 2017-02-20T17:57:11Z

Coverage remained the same at 78.817% when pulling 9d0e352 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

purp · 2017-02-20T23:36:46Z

Okay, testing seems to show that this works for bootstrapping as well. If it passes, I'm all done here.

Thanks, @hennevogel!

coveralls · 2017-02-20T23:40:35Z

Coverage remained the same at 78.817% when pulling 3566e99 on purp:developer_bootstrap_improvements into 3e1d527 on SUSE:master.

hennevogel · 2017-02-21T10:22:53Z

Thank you @purp for your awesome contribution 💐 🎆 🍀

purp added 3 commits February 12, 2017 17:08

Replace sqlite3 example with vagrant example

bd3f31c

The sqlite example won’t work in development due to dependencies on ThinkingSphinx, which doesn’t support sqlite3. The vagrant example works fine in non-vagrant setups.

Add dev:bootstrap

7b7695f

Add rake task to bootstrap dev setup. * Copy config examples in place * Perform bundle:install * Check for Sphinx install * generate Sphinx configs (via ThinkingSphinx) * generate Sphinx indices

Add RSpec config

bff12b4

Add MySQL config for Travis CI

07c2900

purp added 2 commits February 15, 2017 13:06

Remove sqlite3 gem

fbe32c1

Not needed for travis-ci anymore

Add travis gem

dddf262

Allows `travis lint` for checking travis config

purp and others added 4 commits February 15, 2017 13:27

Merge pull request SUSE#162 from purp/depreciation_cleanups

151d47f

Depreciation cleanups

hennevogel requested changes Feb 16, 2017

View reviewed changes

purp added 5 commits February 16, 2017 09:11

Remove explicit TRAVIS environment variable

2d0d849

As @hennevogel points out, this is a default set by Travis CI.

Use rake to create database

0b109a6

Don't include travis gem

2bd4d86

It adds a kerjillion dependencies.

Update Gemfile.lock to exclude travis gem

6b29d6b

Move db:create into before_script

18a5940

`rake` is evidently not available on the system in `before_install`

Use dev:bootstrap in Travis CI

6298fb1

hennevogel approved these changes Feb 17, 2017

View reviewed changes

mdeniz and others added 2 commits February 18, 2017 00:58

[dist] Reorganize Vagrantfile and gitignore vendor/bundle

7d4cc53

Copy sample config files properly

a0d1b05

* Rails.root.join was overcomplicated * I forgot to include the actual copy command =\

purp added 2 commits February 17, 2017 21:09

Don't overwrite existing configs

6cb1482

Update README

a319633

Fetch Sphinx English language morphology pack

b41622a

hennevogel and others added 19 commits February 20, 2017 14:14

Add hackweek 15 intro video

0660de7

Merge pull request SUSE#166 from hennevogel/master

dcd42cf

Add hackweek 15 intro video

Replace sqlite3 example with vagrant example

094bfd4

The sqlite example won’t work in development due to dependencies on ThinkingSphinx, which doesn’t support sqlite3. The vagrant example works fine in non-vagrant setups.

Add dev:bootstrap

efabf59

Add rake task to bootstrap dev setup. * Copy config examples in place * Perform bundle:install * Check for Sphinx install * generate Sphinx configs (via ThinkingSphinx) * generate Sphinx indices

Add RSpec config

9b1ffa3

Add MySQL config for Travis CI

8c1e373

Remove sqlite3 gem

13c8f29

Not needed for travis-ci anymore

Add travis gem

8b69618

Allows `travis lint` for checking travis config

Remove explicit TRAVIS environment variable

90bb039

As @hennevogel points out, this is a default set by Travis CI.

Use rake to create database

448278c

Don't include travis gem

5507524

It adds a kerjillion dependencies.

Update Gemfile.lock to exclude travis gem

2d15f45

Move db:create into before_script

79d7531

`rake` is evidently not available on the system in `before_install`

Use dev:bootstrap in Travis CI

f2beece

Copy sample config files properly

313746a

* Rails.root.join was overcomplicated * I forgot to include the actual copy command =\

Don't overwrite existing configs

ae460f1

Update README

aa2208b

Fetch Sphinx English language morphology pack

feaeb63

Merge branch 'developer_bootstrap_improvements' of https://github.com…

9d0e352

…/purp/hackweek into developer_bootstrap_improvements

purp added 3 commits February 20, 2017 15:35

Use dev:bootstrap while provisioning vagrant VM

c84dad7

Revise README for vagrant dev setup

a98a4ee

Mirror wording of bootstrap.sh

3566e99

hennevogel merged commit a0d25b0 into SUSE:master Feb 21, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Developer bootstrap improvements #161

Developer bootstrap improvements #161

purp commented Feb 15, 2017

purp commented Feb 15, 2017

coveralls commented Feb 15, 2017

coveralls commented Feb 15, 2017

hennevogel Feb 16, 2017

purp Feb 16, 2017

hennevogel Feb 16, 2017

purp Feb 16, 2017

hennevogel Feb 16, 2017

purp Feb 16, 2017

hennevogel Feb 16, 2017

purp Feb 16, 2017

hennevogel Feb 17, 2017

purp Feb 17, 2017

coveralls commented Feb 16, 2017

purp commented Feb 17, 2017

coveralls commented Feb 18, 2017

coveralls commented Feb 18, 2017

hennevogel commented Feb 20, 2017

hennevogel commented Feb 20, 2017

purp commented Feb 20, 2017

coveralls commented Feb 20, 2017

purp commented Feb 20, 2017

coveralls commented Feb 20, 2017

hennevogel commented Feb 21, 2017

		@@ -0,0 +1,51 @@
		# Don't add any includes that aren't in the Ruby std-lib here,

Developer bootstrap improvements #161

Developer bootstrap improvements #161

Conversation

purp commented Feb 15, 2017

purp commented Feb 15, 2017

coveralls commented Feb 15, 2017

coveralls commented Feb 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Feb 16, 2017

purp commented Feb 17, 2017

coveralls commented Feb 18, 2017

coveralls commented Feb 18, 2017

hennevogel commented Feb 20, 2017

hennevogel commented Feb 20, 2017

purp commented Feb 20, 2017

coveralls commented Feb 20, 2017

purp commented Feb 20, 2017

coveralls commented Feb 20, 2017

hennevogel commented Feb 21, 2017