Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check in Works on tab what is rendered && refactoring #187

Merged
merged 3 commits into from
Nov 27, 2017
Merged

Check in Works on tab what is rendered && refactoring #187

merged 3 commits into from
Nov 27, 2017

Conversation

Ana06
Copy link
Contributor

@Ana06 Ana06 commented Nov 15, 2017

That tab should be what the user is currently working on and then the number is different and is confusing for the user.

I also removed some unused branch/conditions. :bowtie:

Solves #186.

The unless is in a block where the condition is already checked, so it
is always `true`.
The if is inside of a another if with the opossite condition, so it is
never used.
That tab should be what the user is currently working on and then
the number is different and is confusing for the user.

Solves #186.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.125% when pulling c199e4e on Ana06:number-work into aa0236c on SUSE:master.

@mdeniz mdeniz merged commit dc687db into SUSE:master Nov 27, 2017
@Ana06 Ana06 deleted the number-work branch April 30, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants