Show the real count of comments made by a user #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I didn't test this in the UI. |
DavidKang
suggested changes
Nov 25, 2018
app/views/users/_buttons.html.haml
Outdated
| / FIXME. Use real count | ||
| .btn.btn-default{:title=>"#{user.name} wrote #{user.projects.length} comments"} | ||
| 0 | ||
| .btn.btn-default{:title=>"#{user.name} wrote #{Comments.where(commenter_id: user).count} comments"} |
There was a problem hiding this comment.
This should be Comment instead of Comments.
BTW, this could be also written as: user.comments.size and in the relationship with comments we should add the foreign_key. Something like has_many :comments, foreign_key: 'commenter_id'
bgeuken
force-pushed
the
fix_showing_count_of_user_comments
branch
from
081921b
to
cb66b2d
Compare
bgeuken
force-pushed
the
fix_showing_count_of_user_comments
branch
from
cb66b2d
to
eb17a36
Compare
DavidKang
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.