Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop: 0.79.0 → 0.81.0 (major) #610

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 2, 2020

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (0.79.0 → 0.81.0) · Repo · Changelog

Release Notes

0.81.0

New features

  • #7299: Add new Lint/RaiseException cop. (@denys281)
  • #7793: Prefer include? over member? in Style/CollectionMethods. (@dmolesUC)
  • #7654: Support with_fixed_indentation option for Layout/ArrayAlignment cop. (@nikitasakov)
  • #7783: Support Ruby 2.7's numbered parameter for Style/RedundantSort. (@koic)
  • #7795: Make Layout/EmptyLineAfterGuardClause aware of case where and or or is used before keyword that break control (e.g. and return). (@koic)
  • #7786: Support Ruby 2.7's pattern match for Layout/ElseAlignment cop. (@koic)
  • #7784: Support Ruby 2.7's numbered parameter for Lint/SafeNavigationChain. (@koic)
  • #7331: Add forbidden option to Style/ModuleFunction cop. (@weh)
  • #7699: Add new Lint/StructNewOverride cop. (@ybiquitous)
  • #7637: Add new Style/TrailingCommaInBlockArgs cop. (@pawptart)
  • #7809: Add auto-correction for Style/EndBlock cop. (@tejasbubane)
  • #7739: Add IgnoreNotImplementedMethods configuration to Lint/UnusedMethodArgument. (@tejasbubane)
  • #7740: Add AllowModifiersOnSymbols configuration to Style/AccessModifierDeclarations. (@tejasbubane)
  • #7812: Add auto-correction for Lint/BooleanSymbol cop. (@tejasbubane)
  • #7823: Add IgnoredMethods configuration in Metrics/AbcSize, Metrics/CyclomaticComplexity, and Metrics/PerceivedComplexity cops. (@drenmi)
  • #7816: Support Ruby 2.7's numbered parameter for Style/Lambda. (@koic)
  • #7829: Fix an error for Style/OneLineConditional when one of the branches contains next keyword. (@koic)

Bug fixes

  • #7236: Mark Style/InverseMethods auto-correct as incompatible with Style/SymbolProc. (@drenmi)
  • #7144: Fix Style/Documentation constant visibility declaration in namespace. (@AdrienSldy)
  • #7779: Fix a false positive for Style/MultilineMethodCallIndentation when using Ruby 2.7's numbered parameter. (@koic)
  • #7733: Fix rubocop-junit-formatter imcompatibility XML for JUnit formatter. (@koic)
  • #7767: Skip array literals in Style/HashTransformValues and Style/HashTransformKeys. (@tejasbubane)
  • #7791: Fix an error on auto-correction for Layout/BlockEndNewline when } of multiline block without processing is not on its own line. (@koic)
  • #7778: Fix a false positive for Layout/EndAlignment when a non-whitespace is used before the end keyword. (@koic)
  • #7806: Fix an error for Lint/ErbNewArguments cop when inspecting ActionView::Template::Handlers::ERB.new. (@koic)
  • #7814: Fix a false positive for Migrate/DepartmentName cop when inspecting an unexpected disabled comment format. (@koic)
  • #7728: Fix an error for Style/OneLineConditional when one of the branches contains a self keyword. (@koic)
  • #7825: Fix crash for Layout/MultilineMethodCallIndentation with key access to hash. (@tejasbubane)
  • #7831: Fix a false positive for Style/HashEachMethods when receiver is implicit. (@koic)

Changes

  • #7797: Allow unicode-display_width dependency version 1.7.0. (@yuritomanek)
  • #7779: Change AllowComments option of Lint/SuppressedException to true by default. (@koic)
  • #7320: Naming/MethodName now flags attr_reader/attr_writer/attr_accessor/attr. (@denys281)
  • #7813: (Breaking) Remove Lint/EndInMethod cop. (@tejasbubane)

0.80.1

Bug fixes

  • #7719: Fix Style/NestedParenthesizedCalls cop for newline. (@tejasbubane)
  • #7709: Fix correction of Style/RedundantCondition when the else branch contains a range. (@rrosenblum)
  • #7682: Fix Style/InverseMethods autofix leaving parenthesis. (@tejasbubane)
  • #7745: Suppress a pending cop warnings when pending cop's department is disabled. (@koic)
  • #7759: Fix an error for Layout/LineLength cop when using lambda syntax that argument is not enclosed in parentheses. (@koic)

Changes

  • #7765: When warning about a pending cop, display the version with the cop added. (@koic)

0.80.0

New features

  • #7693: NodePattern: Add ` for descendant search. (@marcandre)
  • #7577: Add AllowGemfileRubyComment configuration on Layout/LeadingCommentSpace. (@cetinajero)
  • #7663: Add new Style/HashTransformKeys and Style/HashTransformValues cops. (@djudd, @eugeneius)
  • #7619: Support autocorrect of legacy cop names for Migration/DepartmentName. (@koic)
  • #7659: Layout/LineLength autocorrect now breaks up long lines with blocks. (@maxh)
  • #7677: Add a cop for Hash#each_key and Hash#each_value. (@jemmaissroff)
  • Add BracesRequiredMethods parameter to Style/BlockDelimiters to require braces for specific methods such as Sorbet's sig. (@maxh)
  • #7686: Add new JUnitFormatter formatter based on rubocop-junit-formatter gem. (@koic)
  • #7715: Add Steepfile to default Include list. (@ybiquitous)

Bug fixes

  • #7644: Fix patterns with named wildcards in unions. (@marcandre)
  • #7639: Fix logical operator edge case in omit_parentheses style of Style/MethodCallWithArgsParentheses. (@gsamokovarov)
  • #7661: Fix to return correct info from multi-line regexp. (@Tietew)
  • #7655: Fix an error when processing a regexp with a line break at the start of capture parenthesis. (@koic)
  • #7647: Fix an undefined method on_numblock error when using Ruby 2.7's numbered parameters. (@hanachin)
  • #7675: Fix a false negative for Layout/SpaceBeforeFirstArg when a vertical argument positions are aligned. (@koic)
  • #7688: Fix a bug in Style/MethodCallWithArgsParentheses that made --auto-gen-config crash. (@buehmann)
  • #7203: Fix an infinite loop error for Style/TernaryParentheses with Style/RedundantParentheses when using EnforcedStyle: require_parentheses_when_complex. (@koic)
  • #7708: Make it possible to use EOL rubocop:disable comments on comment lines. (@jonas054)
  • #7712: Fix an incorrect autocorrect for Style/OrAssignment when using elsif branch. (@koic)

Changes

  • #7636: Remove console from Lint/Debugger to prevent false positives. (@gsamokovarov)
  • #7641: (Breaking) Remove Style/BracesAroundHashParameters cop. (@pocke)
  • Add the method name to highlight area of Layout/EmptyLineBetweenDefs to help provide more context. (@rrosenblum)
  • #7652: Allow pp to allowed names of Naming/MethodParameterName cop in default config. (@masarakki)
  • #7309: Mark Lint/UselessSetterCall an "not safe" and improve documentation. (@jonas054)
  • #7723: Enable Migration/DepartmentName cop by default. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 2.7.0.2 → 2.7.1.0) · Repo · Changelog

Release Notes

2.7.1.0 (from changelog)

API modifications:

  • Bump ruby versions to 2.4.10, 2.5.8, 2.6.6, 2.7.1. (#665) (Ilya Bylich)

Features implemented:

  • ruby27.y: allow newlines inside braced pattern. (#664) (Ilya Bylich)
  • ruby27.y: Allow trailing comma in hash pattern (#661) (Koichi ITO)

2.7.0.5 (from changelog)

Features implemented:

  • ruby27.y: fix array pattern with tail source map (#659) (Vladimir Dementyev)

Bugs fixed:

  • builder.rb: fix constant_pattern source map (#660) (Vladimir Dementyev)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 19 commits:

↗️ unicode-display_width (indirect, 1.6.1 → 1.7.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 2 commits:

🆕 rexml (added, 3.2.4)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Apr 2, 2020
@DavidKang
Copy link
Contributor

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-0.81.0 branch from 64a2213 to d2b1522 Compare April 6, 2020 07:42
@depfu depfu bot changed the title Update rubocop: 0.79.0 → 0.81.0 (major) Update rubocop: 0.79.0 → 0.81.0 (major) Apr 6, 2020
@DavidKang DavidKang merged commit ef4d09c into master Apr 7, 2020
@depfu depfu bot deleted the depfu/update/rubocop-0.81.0 branch April 7, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant