Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Update kaminari: 1.2.0 → 1.2.1 (patch) #635

Merged
merged 1 commit into from
Oct 10, 2020

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented May 28, 2020


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ kaminari (1.2.0 → 1.2.1) · Repo · Changelog

Security Advisories 🚨

🚨 Cross-Site Scripting in Kaminari via `original_script_name` parameter

Impact

There was a vulnerability in versions of Kaminari that would allow an attacker to inject arbitrary code into pages with pagination links.

For example, an attacker could craft pagination links that link to other domain or host:
https://example.com/posts?page=4&original_script_name=https://another-host.example.com

In addition, an attacker could also craft pagination links that include JavaScript code that runs when a user clicks the link:
https://example.com/posts?page=4&original_script_name=javascript:alert(42)%3b//

Releases

The 1.2.1 gem including the patch has already been released.
All past released versions are affected by this vulnerability.

Workarounds

Application developers who can't update the gem can workaround by overriding the PARAM_KEY_EXCEPT_LIST constant.

module Kaminari::Helpers
  PARAM_KEY_EXCEPT_LIST = [:authenticity_token, :commit, :utf8, :_method, :script_name, :original_script_name].freeze
end
Release Notes

1.2.1 (from changelog)

Security Fixes:

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ kaminari-actionview (indirect, 1.2.0 → 1.2.1) · Repo · Changelog

Release Notes

1.2.1 (from changelog)

Security Fixes:

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ kaminari-activerecord (indirect, 1.2.0 → 1.2.1) · Repo · Changelog

Release Notes

1.2.1 (from changelog)

Security Fixes:

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ kaminari-core (indirect, 1.2.0 → 1.2.1) · Repo · Changelog

Release Notes

1.2.1 (from changelog)

Security Fixes:

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label May 28, 2020
@depfu depfu bot changed the title Update kaminari: 1.2.0 → 1.2.1 (patch) 🚨 [security] Update kaminari: 1.2.0 → 1.2.1 (patch) May 30, 2020
@hennevogel
Copy link
Member

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/kaminari-1.2.1 branch from 08475d4 to 4b1d59f Compare October 10, 2020 15:44
@hennevogel hennevogel merged commit 044d3a5 into master Oct 10, 2020
@depfu depfu bot deleted the depfu/update/kaminari-1.2.1 branch October 10, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant