[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_150701_improve_compare_output' #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +42,7 @@ class BarBazScope < Machinery::Object | |||
| end | |||
|
|
|||
| class BarBazRenderer < Renderer | |||
| def do_render | |||
| def content(description) | |||
There was a problem hiding this comment.
Unused method argument - description. If it's necessary, use _ or _description as an argument name to indicate that it won't be used. You can also write as content(*) if you want the method to accept any arguments but don't care about them.
Comparison#compare_scope returns a Comparison::result which can be used like that: comparison.name1 # name of description 1 comparison.name2 # name of description 2 comparison.only_in1 # partial scope of data only in description 1 comparison.only_in2 # partial scope of data only in description 2 comparison.changed # elements in both with changed attributes comparison.common # partial scope of data in both descriptions comparison.as_description(:one) # methods for returning the according comparison.as_description(:two) # data wrapped into a SystemDescription comparison.as_description(:common)
There is now a well defined set of "content*" methods that are supposed to be overriden in the subclasses. That makes the separation of the responsibilities clearer.
aduffeck
force-pushed
the
review_150701_improve_compare_output
branch
from
e45b437
to
7f97b2c
Compare
| # you may find current contact information at www.suse.com | ||
|
|
||
| class Comparison | ||
| class Result |
There was a problem hiding this comment.
Is this inner class really needed? Couldn't the Comparison class itself have all the methods?
aduffeck
force-pushed
the
review_150701_improve_compare_output
branch
from
b8b2bbb
to
4cd6a68
Compare
|
lgtm |
aduffeck
added a commit
that referenced
this pull request
Jul 2, 2015
[Review] Request from 'aduffeck' @ 'SUSE/machinery/review_150701_improve_compare_output'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the following changes: