Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move EKS jobs cleanup to cleanup_k8s.py script #213

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Move EKS jobs cleanup to cleanup_k8s.py script #213

merged 1 commit into from
Mar 20, 2023

Conversation

ilausuch
Copy link
Contributor

asmorodskyi
asmorodskyi reviewed Feb 21, 2023
View reviewed changes
ocw/lib/eks.py Outdated Show resolved Hide resolved
@ilausuch
Copy link
Contributor Author

I am working on the test for eks

@ilausuch ilausuch force-pushed the eks_jobs_cleanup branch 3 times, most recently from 6e49a40 to e374289 Compare February 22, 2023 12:03
@ilausuch ilausuch changed the title Move EKS jobs cleanup to cleanup_k8s.py script Solves the problem in eks class depending on django for having inherited from ec2 Mar 2, 2023
@ilausuch ilausuch changed the title Solves the problem in eks class depending on django for having inherited from ec2 Move EKS jobs cleanup to cleanup_k8s.py script Mar 2, 2023
@ilausuch ilausuch force-pushed the eks_jobs_cleanup branch 2 times, most recently from dfab8fb to 1d86445 Compare March 20, 2023 13:17
@ilausuch
Copy link
Contributor Author

Test done

ricardobranco777
ricardobranco777 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion. Otherwise LGTM

ocw/lib/eks.py Outdated Show resolved Hide resolved
@asmorodskyi
Copy link
Collaborator

generally looks good , just some minor questions , see in line

@asmorodskyi asmorodskyi merged commit 992a2e1 into SUSE:master Mar 20, 2023
@ricardobranco777 ricardobranco777 mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorodskyi asmorodskyi asmorodskyi left review comments

@ricardobranco777 ricardobranco777 ricardobranco777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilausuch @asmorodskyi @ricardobranco777