Raise Exception on precheck failures #28
Conversation
| @@ -436,6 +443,9 @@ def main(): | |||
| check_target_schema(db['target']) | |||
| cfg.CONF.command.func(cfg, db['source'], db['target']) | |||
|
|
|||
| except Psql2MysqlRuntimeError as e: | |||
| print(e, file=sys.stderr) | |||
| sys.exit(1) | |||
There was a problem hiding this comment.
Would it make sense to distinguish exit codes from the other ones (e.g. from failure during migration)?
There was a problem hiding this comment.
Not sure. Would it help us much?
| raise Psql2MysqlRuntimeError( | ||
| "Errors were found during prechecks. Please address the reported " | ||
| "issues manually and try again." | ||
| ) |
There was a problem hiding this comment.
I still unsure if it might be better to exit upon first problem found. Instead of collection all problems of the database at once.
There was a problem hiding this comment.
May be.
On the other hand, if you have many small errors that are easy to fix, it might be better to fix of them before running the tool again.
There was a problem hiding this comment.
Yeah. I'll just leave it as is for now.
|
rebased and added unittest |
| dbdatamigrator.target_db = mock.MagicMock() | ||
| dbdatamigrator.target_db.getTables.return_value = {'foo': foo} | ||
| dbdatamigrator.target_db.getSortedTables.return_value = [foo] | ||
| with self.assertRaises(psql2mysql.Psql2MysqlRuntimeError): |
There was a problem hiding this comment.
I'd also prefer the exception message was checked here.
rhafer
force-pushed
the
exitcode
branch
2 times, most recently
from
2cbfa38
to
3adbda5
Compare
This introduces a custom RuntimeError Exception that is raised if something goes wrong during the prechecks or migration. Addtionally we make sure to use a non-zero exit code if any of the prechecks fail. And it case of batch processings we stop the batch now after finding errors in a database.
If the target table does not exist throw an error before trying to access it for setting up sqlalchemy type decorators. Added unit test for this.
| @@ -100,3 +100,20 @@ def test_migrate(self): | |||
| dbdatamigrator.src_db.readTableRows.assert_called_with(foo) | |||
| dbdatamigrator.target_db.clearTable.assert_called_with(foo) | |||
| dbdatamigrator.target_db.writeTableRows.assert_called_once() | |||
|
|
|||
| def test_migrate_target_missing(self): | |||
| chunk_size = 10 | |||
There was a problem hiding this comment.
Nit: We don't need to set chunk_size or pass it the DbDataMigrator constructor
This introduces a custom RuntimeError Exception that is raised if
something goes wrong during the prechecks or migration.
Addtionally we make sure to use a non-zero exit code if any of the
prechecks fail. And it case of batch processings we stop the batch
now after finding errors in a database.