Exclude deleted items from queries. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsuchome
commented
Sep 10, 2018
•
jsuchome
commented
- excluding deleted items should make the migration faster
- it is even necessary when user deletes the items that do not pass the precheck (like wrong UTF chars)
rhafer
suggested changes
Sep 10, 2018
psql2mysql.py
Outdated
| def _exclude_deleted(self, table, query): | ||
| if not "deleted" in table.columns: | ||
| return query | ||
| if isinstance(table.columns["deleted"].type, types.INTEGER): |
There was a problem hiding this comment.
Is does this really work? It seems that e.g. manila is using "varchar" for some if the "deleted" columns for whatever reason.
There was a problem hiding this comment.
I was already surprised that there's a Int type of 'deleted' and you're saying there could be more?
There was a problem hiding this comment.
Oh, manila tables really have them all, deleted as Boolean, Integer and String :-)
jsuchome
force-pushed
the
ignore-deleted
branch
from
04924b7
to
25a9046
Compare
rhafer
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.