API Fix: service name

Notes:

In glue, the api appends release_stage (Alpha/Beta/...) to the product's
friendly_name in the serializer. The service serializer expects the
product's friendly name without the release_stage, but as the appended
version is saved in the db and used, we need to make a clean version of
friendly_name.

app/models/service.rb

@@ -12,7 +12,11 @@ class Service < ApplicationRecord
   validates :product_id, presence: true
 
   def name
-    product.friendly_name.tr(' ', '_')
+    [
+      product.name,
+      product.release_type,
+      (product.arch if product.arch != 'unknown')
+    ].compact.join(' ').tr(' ', '_')
   end
 
 end

spec/models/service_spec.rb

@@ -13,9 +13,9 @@
     context 'when has enabled and disabled repos' do
       subject { service.enabled_repositories }
 
-      let(:service) { FactoryGirl.create(:service) }
-      let(:enabled_repository) { FactoryGirl.create(:repository) }
-      let(:disabled_repository) { FactoryGirl.create(:repository, enabled: false) }
+      let(:service) { create(:service) }
+      let(:enabled_repository) { create(:repository) }
+      let(:disabled_repository) { create(:repository, enabled: false) }
 
       before do
         service.repositories << enabled_repository
@@ -26,4 +26,19 @@
       it { is_expected.not_to include disabled_repository }
     end
   end
+
+  describe '#name' do
+    shared_examples 'service name' do |product_attributes, expected|
+      subject { create(:service, product: product).name }
+
+      let(:product) { create(:product, name: product_attributes[:name], release_type: product_attributes[:release_type], arch: product_attributes[:arch]) }
+
+      it { is_expected.to eq(expected) }
+    end
+
+    it_behaves_like 'service name', { name: 'SLES Special Product 1', arch: 'x86_64' }, 'SLES_Special_Product_1_x86_64'
+    it_behaves_like 'service name', { name: 'SLES Special Product 1', release_type: 'Online', arch: 'x86_64' }, 'SLES_Special_Product_1_Online_x86_64'
+    it_behaves_like 'service name', { name: 'SLES Special Product 1', arch: 'unknown' }, 'SLES_Special_Product_1'
+    it_behaves_like 'service name', { name: 'SLES Special Product 1', release_type: 'Online', arch: 'unknown' }, 'SLES_Special_Product_1_Online'
+  end
 end