Merge pull request #169 from SUSE/fix-eula-url

Fix eula_url in product serializer

app/serializers/v3/product_serializer.rb

@@ -25,7 +25,7 @@ def arch
   end
 
   def eula_url
-    if object.eula_url
+    if object.eula_url.present?
       RMT::Misc.replace_uri_parts(object.eula_url, base_url + RMT::DEFAULT_MIRROR_URL_PREFIX)
     else
       ''

spec/serializers/v3/product_serializer_spec.rb

@@ -11,6 +11,30 @@
   end
   let(:base_url) { 'http://example.com' }
 
+  describe '#eula_url' do
+    subject { described_class.new(product, base_url: base_url).eula_url }
+
+    let(:product) { create :product, eula_url: eula_url }
+
+    context "when the product's eula_url is an empty string" do
+      let(:eula_url) { '' }
+
+      it { is_expected.to eq '' }
+    end
+
+    context "when the product's eula_url is nil" do
+      let(:eula_url) { nil }
+
+      it { is_expected.to eq '' }
+    end
+
+    context "when the product's eula_url is a URL" do
+      let(:eula_url) { 'http://example.com/eula' }
+
+      it { is_expected.to eq 'http://example.com/repo/eula' }
+    end
+  end
+
   describe 'SLES extension tree' do
     subject(:serializer) { described_class.new(sles15, root_product: sles15, base_url: base_url) }