Use the recommended systemd config #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikapelyukhin
approved these changes
Apr 4, 2018
| User=_rmt | ||
| PrivateTmp=yes | ||
| Environment=RAILS_LOG_TO_STDOUT=1 |
There was a problem hiding this comment.
Looks good, but I'd suggest making changes to the RPM package as well -- currently it creates an empty log directory to store file logs. It can be dropped now.
There was a problem hiding this comment.
Does 923488d look good?
There was a problem hiding this comment.
Cool. I can't merge until we merge the parser gem fix xD
Puma specifies a recommended way of starting it with systemd at: https://github.com/puma/puma/blob/5fb2df9144803f0f80ec1d9fb19d20d433706fef/docs/systemd.md#service-configuration Type=simple can be used, and then there's not need to --daemon the Rails server. Additionally, we set the RAILS_LOG_TO_STDOUT variable, so that Rails outputs its log to stdout. This allows for the logs to be saved and visible in journalctl. The PrivateTmp option "sets up a new file system namespace for the executed processes and mounts private /tmp and /var/tmp directories inside it that is not shared by processes outside of the namespace. (...) all temporary files created by a service in these directories will be removed after the service is stopped." Since RMT creates some temporary directories while mirroring, with this option we isolate them and make sure they get deleted when RMT is stopped. Closes #128.
Since the logs are stored by journalctl, that directory is no longer necessary.
lagartoflojo
force-pushed
the
proper-systemd-service
branch
from
923488d
to
d491827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma specifies a recommended way of starting it with systemd at:
https://github.com/puma/puma/blob/5fb2df9144803f0f80ec1d9fb19d20d433706fef/docs/systemd.md#service-configuration
Type=simple can be used, and then there's not need to --daemon the Rails
server.
Additionally, we set the RAILS_LOG_TO_STDOUT variable, so that Rails
outputs its log to stdout. This allows for the logs to be saved and
visible in journalctl.
The PrivateTmp option "sets up a new file system namespace for the
executed processes and mounts private /tmp and /var/tmp directories
inside it that is not shared by processes outside of the namespace.
(...) all temporary files created by a service in these directories will
be removed after the service is stopped."
Since RMT creates some temporary directories while mirroring, with this
option we isolate them and make sure they get deleted when RMT is
stopped.